Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2671483002: [Telemetry] Migrate browser_test_runner to use typ as the test runner (Closed)

Created:
3 years, 10 months ago by nednguyen
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Migrate browser_test_runner to use typ as the test runner This is a reland of https://codereview.chromium.org/2590623002/. The previous work was reverted because it makes setUpClass & tearDownClass between every single test, causes the webgl_conformance suite to time out. To fix that, this introduces SetUpProcess & TearDownProcess class methods to SeriallyExecutedBrowserTestCase which are guaranteed to be called once before & after the test suite is run. Patch 1 is the original work, patch 2 & beyond includes extra logic for SetUpProcess & TearDownProcess BUG=chromium:636153 Review-Url: https://codereview.chromium.org/2671483002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c6c6d50501b4c2890c4ac60757717c2b942e5358

Patch Set 1 #

Patch Set 2 : Add SetUpProcess & TearDownProcess methods & unittest #

Total comments: 2

Patch Set 3 : Address Ken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -547 lines) Patch
M telemetry/bin/run_browser_tests View 1 chunk +1 line, -2 lines 0 comments Download
M telemetry/examples/browser_tests/failed_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + telemetry/examples/browser_tests/process_tests.py View 1 2 chunks +17 lines, -11 lines 0 comments Download
A telemetry/examples/browser_tests/sample_unittest.py View 1 chunk +12 lines, -0 lines 0 comments Download
M telemetry/examples/browser_tests/simple_browser_test.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A telemetry/telemetry/testing/browser_test_context.py View 1 1 chunk +74 lines, -0 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner.py View 1 chunk +32 lines, -308 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner_unittest.py View 1 2 10 chunks +156 lines, -105 lines 0 comments Download
A + telemetry/telemetry/testing/run_browser_tests.py View 1 5 chunks +153 lines, -109 lines 0 comments Download
M telemetry/telemetry/testing/serially_executed_browser_test_case.py View 1 4 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
nednguyen
3 years, 10 months ago (2017-02-01 15:51:15 UTC) #3
nednguyen
On 2017/02/01 15:51:15, nednguyen wrote: Ping
3 years, 10 months ago (2017-02-04 00:13:23 UTC) #9
Ken Russell (switch to Gerrit)
Sorry, I was at conferences most of this week. LGTM to try switching over again. ...
3 years, 10 months ago (2017-02-04 22:14:14 UTC) #10
nednguyen
On 2017/02/04 22:14:14, Ken Russell wrote: > Sorry, I was at conferences most of this ...
3 years, 10 months ago (2017-02-06 19:15:49 UTC) #11
nednguyen
3 years, 10 months ago (2017-02-06 19:18:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671483002/60001
3 years, 10 months ago (2017-02-06 19:19:30 UTC) #15
nednguyen
https://codereview.chromium.org/2671483002/diff/40001/telemetry/telemetry/testing/browser_test_runner_unittest.py File telemetry/telemetry/testing/browser_test_runner_unittest.py (right): https://codereview.chromium.org/2671483002/diff/40001/telemetry/telemetry/testing/browser_test_runner_unittest.py#newcode23 telemetry/telemetry/testing/browser_test_runner_unittest.py:23: def _ExtracTestResults(self, test_result): On 2017/02/04 22:14:14, Ken Russell wrote: ...
3 years, 10 months ago (2017-02-06 19:19:49 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c6c6d50501b4c2890c4ac60757717c2b942e5358
3 years, 10 months ago (2017-02-06 19:41:16 UTC) #19
nednguyen
3 years, 10 months ago (2017-02-06 19:42:29 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2672323003/ by nednguyen@google.com.

The reason for reverting is: Revert so we can try out this change in CHromium
first..

Powered by Google App Engine
This is Rietveld 408576698