Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2672083002: Revert of Set the Ash browser frame color for MD WebUI (Settings) (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set the Ash browser frame color for MD WebUI (Settings) (patchset #3 id:40001 of https://codereview.chromium.org/2676673003/ ) Reason for revert: Broke this builder: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/83127 Original issue's description: > Set the Ash browser frame color for MD WebUI (Settings) > > Currently Settings is the only Web IU we show in a dedicated browser > window on Ash (Chrome OS). > > BUG=684129 > > Review-Url: https://codereview.chromium.org/2676673003 > Cr-Commit-Position: refs/heads/master@{#448024} > Committed: https://chromium.googlesource.com/chromium/src/+/31dc779f1ecd8dabd26dfed11bef773c95ae5b47 TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684129 Review-Url: https://codereview.chromium.org/2672083002 Cr-Commit-Position: refs/heads/master@{#448029} Committed: https://chromium.googlesource.com/chromium/src/+/cc0299554e91edeb02f010a17196a65a21cabdf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 4 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
stevenjb
Created Revert of Set the Ash browser frame color for MD WebUI (Settings)
3 years, 10 months ago (2017-02-03 18:34:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672083002/1
3 years, 10 months ago (2017-02-03 18:34:43 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 18:36:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc0299554e91edeb02f010a17196...

Powered by Google App Engine
This is Rietveld 408576698