Set the Ash browser frame color for MD WebUI (Settings)

Set the Ash browser frame color for MD WebUI (Settings)

Currently Settings is the only Web IU we show in a dedicated browser
window on Ash (Chrome OS).

BUG=684129
Review-Url: https://codereview.chromium.org/2676673003
Cr-Commit-Position: refs/heads/master@{#448024}
Committed: https://chromium.googlesource.com/chromium/src/+/31dc779f1ecd8dabd26dfed11bef773c95ae5b47

[stevenjb, 2017-02-02 22:24:00]

stevenjb@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-02-03 00:38:32]

https://codereview.chromium.org/2676673003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/2676673003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:66: const
SkColor kMdWebUIFrameColor = SkColorSetRGB(0x25, 0x4f, 0xae);
I'm surprised this color isn't common with other places. Is that right? It looks
like this is only used for packaged apps, could you name it like that too? Also,
use constexpr.

https://codereview.chromium.org/2676673003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:111:
header_painter->SetFrameColors(kMdWebUIFrameColor, kMdWebUIFrameColor);
Are we really using the same color for active and inactive?

[stevenjb, 2017-02-03 01:52:43]

https://codereview.chromium.org/2676673003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/2676673003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:66: const
SkColor kMdWebUIFrameColor = SkColorSetRGB(0x25, 0x4f, 0xae);
On 2017/02/03 00:38:32, sky wrote:
> I'm surprised this color isn't common with other places. Is that right? It
looks
> like this is only used for packaged apps, could you name it like that too?
Also,
> use constexpr.

It's actually just for trusted source tabless browser windows, i.e. WebUI.
Specifically this is for Settings which is still the only WebUI with a dedicated
window. If that ever changes and UX wants different colors, we can cross that
bridge when we get there; I am not aware of any desire to do that for anything
except Settings.

I switched all of these to use constexpr.

https://codereview.chromium.org/2676673003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:111:
header_painter->SetFrameColors(kMdWebUIFrameColor, kMdWebUIFrameColor);
On 2017/02/03 00:38:32, sky wrote:
> Are we really using the same color for active and inactive?

I wasn't provided an inactive color, and currently we don't differentiate  for
Settings. I will verify that in the issue.

[sky, 2017-02-03 16:41:13]

LGTM

https://codereview.chromium.org/2676673003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/2676673003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:66: constexpr
SkColor kMdWebUIFrameColor = SkColorSetRGB(0x25, 0x4f, 0xae);
Thanks for a more descriptive name.

[stevenjb, 2017-02-03 17:23:00]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-03 17:23:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 18:07:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486142580373160,
"parent_rev": "a0651393fc46e6637ac0a5bc29c816c3f4ee9088", "commit_rev":
"31dc779f1ecd8dabd26dfed11bef773c95ae5b47"}

[commit-bot: I haz the power, 2017-02-03 18:08:22]

Description was changed from

==========
Set the Ash browser frame color for MD WebUI (Settings)

Currently Settings is the only Web IU we show in a dedicated browser
window on Ash (Chrome OS).

BUG=684129
==========

to

==========
Set the Ash browser frame color for MD WebUI (Settings)

Currently Settings is the only Web IU we show in a dedicated browser
window on Ash (Chrome OS).

BUG=684129

Review-Url: https://codereview.chromium.org/2676673003
Cr-Commit-Position: refs/heads/master@{#448024}
Committed:
https://chromium.googlesource.com/chromium/src/+/31dc779f1ecd8dabd26dfed11bef...
==========

[commit-bot: I haz the power, 2017-02-03 18:08:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/31dc779f1ecd8dabd26dfed11bef...

[stevenjb, 2017-02-03 18:34:16]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2672083002/ by stevenjb@chromium.org.

The reason for reverting is: Broke this builder:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
.

[stevenjb, 2017-02-03 18:57:40]

Patchset #4 (id:60001) has been deleted