Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2672023002: [ios] Prevent multiple page security popups in voice over mode. (Closed)
Patch Set: Correct comment grammar Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/browser_view_controller.h" 5 #import "ios/chrome/browser/ui/browser_view_controller.h"
6 6
7 #import <AssetsLibrary/AssetsLibrary.h> 7 #import <AssetsLibrary/AssetsLibrary.h>
8 #import <MobileCoreServices/MobileCoreServices.h> 8 #import <MobileCoreServices/MobileCoreServices.h>
9 #import <PassKit/PassKit.h> 9 #import <PassKit/PassKit.h>
10 #import <Photos/Photos.h> 10 #import <Photos/Photos.h>
(...skipping 3399 matching lines...) Expand 10 before | Expand all | Expand 10 after
3410 // conditions. However a crash was seen were navItem was NULL hence this 3410 // conditions. However a crash was seen were navItem was NULL hence this
3411 // test after a DCHECK. 3411 // test after a DCHECK.
3412 DCHECK(navItem); 3412 DCHECK(navItem);
3413 if (!navItem) 3413 if (!navItem)
3414 return; 3414 return;
3415 3415
3416 // Don't show if the page is native. 3416 // Don't show if the page is native.
3417 if ([self isTabNativePage:tab]) 3417 if ([self isTabNativePage:tab])
3418 return; 3418 return;
3419 3419
3420 // Don't show the bubble twice (this can happen when tapping very quickly in
3421 // accessibility mode).
3422 if (_pageInfoController)
3423 return;
3424
3420 base::RecordAction(UserMetricsAction("MobileToolbarPageSecurityInfo")); 3425 base::RecordAction(UserMetricsAction("MobileToolbarPageSecurityInfo"));
3421 3426
3422 // Dismiss the omnibox (if open). 3427 // Dismiss the omnibox (if open).
3423 [_toolbarController cancelOmniboxEdit]; 3428 [_toolbarController cancelOmniboxEdit];
3424 3429
3425 [[NSNotificationCenter defaultCenter] 3430 [[NSNotificationCenter defaultCenter]
3426 postNotificationName:ios_internal::kPageInfoWillShowNotification 3431 postNotificationName:ios_internal::kPageInfoWillShowNotification
3427 object:nil]; 3432 object:nil];
3428 3433
3429 // TODO(rohitrao): Get rid of PageInfoModel completely. 3434 // TODO(rohitrao): Get rid of PageInfoModel completely.
(...skipping 1739 matching lines...) Expand 10 before | Expand all | Expand 10 after
5169 5174
5170 - (UIView*)voiceSearchButton { 5175 - (UIView*)voiceSearchButton {
5171 return _voiceSearchButton; 5176 return _voiceSearchButton;
5172 } 5177 }
5173 5178
5174 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner { 5179 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
5175 return [self currentLogoAnimationControllerOwner]; 5180 return [self currentLogoAnimationControllerOwner];
5176 } 5181 }
5177 5182
5178 @end 5183 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698