Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 2671713006: [Cronet] Don't spam log if system cookie doesn't have creation time. (Closed)

Created:
3 years, 10 months ago by mef
Modified:
3 years, 10 months ago
Reviewers:
lilyhoughton, sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Don't spam log if system cookie doesn't have creation time. BUG=688540 TEST=components/cronet/tools/cr_cronet.py build-test | grep "Cookie" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2671713006 Cr-Commit-Position: refs/heads/master@{#448982} Committed: https://chromium.googlesource.com/chromium/src/+/d0581caf436bae2e357a956598b2686092774683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -8 lines) Patch
M components/cronet/ios/test/cronet_http_test.mm View 1 chunk +33 lines, -0 lines 0 comments Download
M ios/BUILD.gn View 1 chunk +2 lines, -5 lines 0 comments Download
A ios/features.gni View 1 chunk +10 lines, -0 lines 0 comments Download
M ios/net/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
mef
Hi, PTAL.
3 years, 10 months ago (2017-02-06 15:55:01 UTC) #8
lilyhoughton
On 2017/02/06 15:55:01, mef wrote: > Hi, PTAL. LGTM. Do you know why the cookies ...
3 years, 10 months ago (2017-02-07 15:29:39 UTC) #9
mef
On 2017/02/07 15:29:39, lilyhoughton wrote: > On 2017/02/06 15:55:01, mef wrote: > > Hi, PTAL. ...
3 years, 10 months ago (2017-02-07 20:21:28 UTC) #10
sdefresne
lgtm
3 years, 10 months ago (2017-02-08 09:36:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671713006/1
3 years, 10 months ago (2017-02-08 12:51:33 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 13:56:21 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0581caf436bae2e357a956598b2...

Powered by Google App Engine
This is Rietveld 408576698