Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: ios/net/cookies/cookie_store_ios.mm

Issue 2671713006: [Cronet] Don't spam log if system cookie doesn't have creation time. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/net/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios.mm
diff --git a/ios/net/cookies/cookie_store_ios.mm b/ios/net/cookies/cookie_store_ios.mm
index fb231140ed3e006115b3921dd3f391a7bd30866f..8576980aca272232bf3e0fb786070f4e505e66ff 100644
--- a/ios/net/cookies/cookie_store_ios.mm
+++ b/ios/net/cookies/cookie_store_ios.mm
@@ -28,6 +28,7 @@
#include "ios/net/cookies/cookie_creation_time_manager.h"
#include "ios/net/cookies/cookie_store_ios_client.h"
#include "ios/net/cookies/system_cookie_util.h"
+#include "ios/net/ios_net_features.h"
#import "net/base/mac/url_conversions.h"
#include "net/cookies/cookie_util.h"
#include "net/cookies/parsed_cookie.h"
@@ -175,11 +176,11 @@ NSInteger CompareCookies(id a, id b, void* context) {
DCHECK(manager);
base::Time created_a = manager->GetCreationTime(cookie_a);
base::Time created_b = manager->GetCreationTime(cookie_b);
-#if !defined(CRNET)
+#if !BUILDFLAG(CRONET_BUILD)
// CookieCreationTimeManager is returning creation times that are null.
- // Since in CrNet, the cookie store is recreated on startup, let's suppress
+ // Since in Cronet, the cookie store is recreated on startup, let's suppress
// this warning for now.
- // TODO(huey): Instead of suppressing the warning, assign a creation time
+ // TODO(mef): Instead of suppressing the warning, assign a creation time
// to cookies if one doesn't already exist.
DLOG_IF(ERROR, created_a.is_null() || created_b.is_null())
<< "Cookie without creation date";
« no previous file with comments | « ios/net/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698