Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2671673002: Make External per-window rather than a static Persistent. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/DOMWindow.h
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h
index db61486664291fa401c291f744e4732298cbf9ad..f306e143dca2dd84e2d5122719516ee4c41710e7 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.h
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h
@@ -207,7 +207,7 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
// Obsolete APIs
void captureEvents() {}
void releaseEvents() {}
- External* external() const;
+ External* external();
// FIXME: This handles both window[index] and window.frames[index]. However,
// the spec exposes window.frames[index] across origins but not
@@ -267,6 +267,7 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
private:
Member<Frame> m_frame;
mutable Member<Location> m_location;
+ Member<External> m_external;
// Set to true when close() has been called. Needed for
// |window.closed| determinism; having it return 'true'
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698