Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2671523002: gpu: Correct GMB format for GL_RGB BackTexture. (Closed)

Created:
3 years, 10 months ago by Daniele Castagna
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851, chrome-os-partner:62472 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2665963002 Cr-Commit-Position: refs/heads/master@{#447340} (cherry picked from commit 5a771c396bea52c449c4e22a15b93973f60488e0) Review-Url: https://codereview.chromium.org/2671523002 . Cr-Commit-Position: refs/branch-heads/2987@{#250} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3aa2f5150aa815142dc94c8a3e8ab52f1ec23573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniele Castagna
3 years, 10 months ago (2017-02-01 19:18:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3aa2f5150aa815142dc94c8a3e8ab52f1ec23573.

Powered by Google App Engine
This is Rietveld 408576698