Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2665963002:
gpu: Correct GMB format for GL_RGB BackTexture. (Closed)
|
Created:
3 years, 10 months ago by Daniele Castagna Modified:
3 years, 10 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Correct GMB format for GL_RGB BackTexture.
When allocating a GMB for the offscreen color texture we should
pick the correct GMB format based on the internalformat of the fb.
We used to always allocate RGBA, with this patch we'll allocate
RGBX in case the internal foramt is GL_RGB.
BUG=680851, chrome-os-partner:62472
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2665963002
Cr-Commit-Position: refs/heads/master@{#447340}
Committed: https://chromium.googlesource.com/chromium/src/+/5a771c396bea52c449c4e22a15b93973f60488e0
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851 ========== to ========== gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
dcastagna@chromium.org changed reviewers: + ccameron@chromium.org, reveman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851,chrome-os-partner:62472 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dcastagna@chromium.org changed reviewers: + jbauman@chromium.org
I thought ccameron was an owner of command_buffer. Adding jbauman for ownership.
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485899064475240, "parent_rev":
"3acb55665c4761345907f1fcc13027eb69c1bf95", "commit_rev":
"5a771c396bea52c449c4e22a15b93973f60488e0"}
Message was sent while issue was closed.
Description was changed from ========== gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851,chrome-os-partner:62472 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG=680851,chrome-os-partner:62472 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2665963002 Cr-Commit-Position: refs/heads/master@{#447340} Committed: https://chromium.googlesource.com/chromium/src/+/5a771c396bea52c449c4e22a15b9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5a771c396bea52c449c4e22a15b9... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
