components/metrics/metrics_log_unittest.cc - Issue 2671433002: Don't set cpu architecture field on iOS in UMA logs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_log_unittest.cc

Issue 2671433002: Don't set cpu architecture field on iOS in UMA logs. (Closed)

Patch Set: Fix test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/metrics_log_unittest.cc

diff --git a/components/metrics/metrics_log_unittest.cc b/components/metrics/metrics_log_unittest.cc

index 8596b738338b3832df4831b74d968db5d9bfa814..6cf3c4a358eddc9db9b8f02d66cf447f1093ae55 100644

--- a/components/metrics/metrics_log_unittest.cc

+++ b/components/metrics/metrics_log_unittest.cc

@@ -195,7 +195,9 @@ TEST_F(MetricsLogTest, BasicRecord) {

#endif

metrics::SystemProfileProto::Hardware* hardware =

system_profile->mutable_hardware();

+#if !defined(OS_IOS)

hardware->set_cpu_architecture(base::SysInfo::OperatingSystemArchitecture());

+#endif

hardware->set_system_ram_mb(base::SysInfo::AmountOfPhysicalMemoryMB());

hardware->set_hardware_class(base::SysInfo::HardwareModelName());

#if defined(OS_WIN)

« no previous file with comments | « components/metrics/metrics_log.cc ('k') | no next file » | no next file with comments »