Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2671333004: Convert class-full-of-statics CryptoTestUtils into a namespace (Closed)

Created:
3 years, 10 months ago by Fan Yang
Modified:
3 years, 10 months ago
Reviewers:
gredner, Ryan Hamilton, gredner
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert class-full-of-statics CryptoTestUtils into a namespace Merge internal change: 146240722 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -468 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M net/quic/chromium/crypto_test_utils_chromium.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_end_to_end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/cert_compressor_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/channel_id_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_framer_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 32 chunks +35 lines, -35 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 18 chunks +20 lines, -20 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_client_push_promise_index_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_client_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 7 chunks +15 lines, -15 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 9 chunks +13 lines, -12 lines 0 comments Download
M net/quic/core/quic_crypto_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +194 lines, -197 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 21 chunks +77 lines, -99 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_client_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2671303003 Patch 20001

Dependent Patchsets:

Issue 2678953002 Patch 1

Messages

Total messages: 10 (7 generated)
Fan Yang
3 years, 10 months ago (2017-02-06 19:31:54 UTC) #1
gredner
lgtm
3 years, 10 months ago (2017-02-06 19:41:57 UTC) #7
Ryan Hamilton
3 years, 10 months ago (2017-02-06 20:13:03 UTC) #8 
lgtm

Powered by Google App Engine
This is Rietveld 408576698