Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2671333004: Convert class-full-of-statics CryptoTestUtils into a namespace (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_test.cc ('k') | net/tools/quic/quic_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 456622e9dd8e5aa79c8f75fb801fdaadaf7407c2..36070738f2718ff4b00efc919ac89c4d0cc06a9c 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -166,7 +166,7 @@ class MockServerConnection : public MockQuicConnection {
class QuicDispatcherTest : public ::testing::Test {
public:
QuicDispatcherTest()
- : QuicDispatcherTest(CryptoTestUtils::ProofSourceForTesting()) {}
+ : QuicDispatcherTest(crypto_test_utils::ProofSourceForTesting()) {}
explicit QuicDispatcherTest(std::unique_ptr<ProofSource> proof_source)
: helper_(&eps_, QuicAllocator::BUFFER_POOL),
@@ -820,7 +820,7 @@ TEST_P(QuicDispatcherStatelessRejectTest, CheapRejects) {
QUIC_LOG(INFO) << "Params: " << GetParam();
// Process the first packet for the connection.
// clang-format off
- CryptoHandshakeMessage client_hello = CryptoTestUtils::Message(
+ CryptoHandshakeMessage client_hello = crypto_test_utils::Message(
"CHLO",
"AEAD", "AESG",
"KEXS", "C255",
@@ -852,7 +852,7 @@ TEST_P(QuicDispatcherStatelessRejectTest, BufferNonChlo) {
// Process the first packet for the connection.
// clang-format off
- CryptoHandshakeMessage client_hello = CryptoTestUtils::Message(
+ CryptoHandshakeMessage client_hello = crypto_test_utils::Message(
"CHLO",
"AEAD", "AESG",
"KEXS", "C255",
@@ -860,7 +860,7 @@ TEST_P(QuicDispatcherStatelessRejectTest, BufferNonChlo) {
"VER\0", "Q025",
"$padding", static_cast<int>(kClientHelloMinimumSize),
nullptr);
- // clang-format on
+ // clang-format on
// If stateless rejects are enabled then a connection will be created now
// and the buffered packet will be processed
@@ -1170,11 +1170,12 @@ class BufferedPacketStoreTest
clock_ = QuicDispatcherPeer::GetHelper(dispatcher_.get())->GetClock();
QuicVersion version = AllSupportedVersions().front();
- CryptoHandshakeMessage chlo = CryptoTestUtils::GenerateDefaultInchoateCHLO(
- clock_, version, &crypto_config_);
+ CryptoHandshakeMessage chlo =
+ crypto_test_utils::GenerateDefaultInchoateCHLO(clock_, version,
+ &crypto_config_);
chlo.SetVector(net::kCOPT, net::QuicTagVector{net::kSREJ});
// Pass an inchoate CHLO.
- CryptoTestUtils::GenerateFullCHLO(
+ crypto_test_utils::GenerateFullCHLO(
chlo, &crypto_config_, server_addr_, client_addr_, version, clock_,
signed_config_, QuicDispatcherPeer::GetCache(dispatcher_.get()),
&full_chlo_);
@@ -1621,11 +1622,11 @@ class AsyncGetProofTest : public QuicDispatcherTest {
clock_ = QuicDispatcherPeer::GetHelper(dispatcher_.get())->GetClock();
QuicVersion version = AllSupportedVersions().front();
- chlo_ = CryptoTestUtils::GenerateDefaultInchoateCHLO(clock_, version,
- &crypto_config_);
+ chlo_ = crypto_test_utils::GenerateDefaultInchoateCHLO(clock_, version,
+ &crypto_config_);
chlo_.SetVector(net::kCOPT, net::QuicTagVector{net::kSREJ});
// Pass an inchoate CHLO.
- CryptoTestUtils::GenerateFullCHLO(
+ crypto_test_utils::GenerateFullCHLO(
chlo_, &crypto_config_, server_addr_, client_addr_, version, clock_,
signed_config_, QuicDispatcherPeer::GetCache(dispatcher_.get()),
&full_chlo_);
« no previous file with comments | « net/tools/quic/quic_client_test.cc ('k') | net/tools/quic/quic_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698