Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: net/quic/chromium/crypto_test_utils_chromium.cc

Issue 2671333004: Convert class-full-of-statics CryptoTestUtils into a namespace (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/crypto_test_utils_chromium.cc
diff --git a/net/quic/chromium/crypto_test_utils_chromium.cc b/net/quic/chromium/crypto_test_utils_chromium.cc
index a7b8df41020c427711bdfc1c80678a5881f3a74a..691cb18ea01bce23efdb2dbd3e9b45b712c568dd 100644
--- a/net/quic/chromium/crypto_test_utils_chromium.cc
+++ b/net/quic/chromium/crypto_test_utils_chromium.cc
@@ -79,8 +79,9 @@ class TestProofVerifierChromium : public ProofVerifierChromium {
} // namespace
-// static
-std::unique_ptr<ProofSource> CryptoTestUtils::ProofSourceForTesting() {
+namespace crypto_test_utils {
+
+std::unique_ptr<ProofSource> ProofSourceForTesting() {
std::unique_ptr<ProofSourceChromium> source(new ProofSourceChromium());
base::FilePath certs_dir = GetTestCertsDirectory();
CHECK(source->Initialize(
@@ -90,8 +91,7 @@ std::unique_ptr<ProofSource> CryptoTestUtils::ProofSourceForTesting() {
return std::move(source);
}
-// static
-std::unique_ptr<ProofVerifier> CryptoTestUtils::ProofVerifierForTesting() {
+std::unique_ptr<ProofVerifier> ProofVerifierForTesting() {
// TODO(rch): use a real cert verifier?
std::unique_ptr<MockCertVerifier> cert_verifier(new MockCertVerifier());
net::CertVerifyResult verify_result;
@@ -109,12 +109,13 @@ std::unique_ptr<ProofVerifier> CryptoTestUtils::ProofVerifierForTesting() {
base::WrapUnique(new CTPolicyEnforcer), "quic_root.crt");
}
-// static
-ProofVerifyContext* CryptoTestUtils::ProofVerifyContextForTesting() {
+ProofVerifyContext* ProofVerifyContextForTesting() {
return new ProofVerifyContextChromium(/*cert_verify_flags=*/0,
NetLogWithSource());
}
+} // namespace crypto_test_utils
+
} // namespace test
} // namespace net
« no previous file with comments | « net/quic/chromium/crypto/proof_test_chromium.cc ('k') | net/quic/chromium/quic_chromium_client_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698