Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2671263003: Merge 3004: Revert of Remove ScopedVector in components/spellcheck (patchset #5 id:80001 of https:/… (Closed)

Created:
3 years, 10 months ago by Will Harris
Modified:
3 years, 10 months ago
Reviewers:
groby-ooo-7-16, ke.he
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine, mac-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/3004
Project:
chromium
Visibility:
Public.

Description

Merge 3004: Revert of Remove ScopedVector in components/spellcheck (patchset #5 id:80001 of https://codereview.chromium.org/2658013002/ ) Reason for revert: causing crashes on canary see crbug.com/688770 Original issue's description: > Remove ScopedVector in components/spellcheck > > BUG=554289 > > Review-Url: https://codereview.chromium.org/2658013002 > Cr-Commit-Position: refs/heads/master@{#447961} > Committed: https://chromium.googlesource.com/chromium/src/+/293806358ee234776a9f73f05fdb08a3e3e7e78a TBR=groby@chromium.org,ke.he@intel.com BUG=554289, 688770 Review-Url: https://codereview.chromium.org/2680563002 Cr-Commit-Position: refs/heads/master@{#448346} (cherry picked from commit 17ae25764e3d827b1fe4b1671734811d877839f6) Review-Url: https://codereview.chromium.org/2671263003 . Cr-Commit-Position: refs/branch-heads/3004@{#3} Cr-Branched-From: 604a36b20d9ffe65380031f3f708d859d81f71be-refs/heads/master@{#448183} Committed: https://chromium.googlesource.com/chromium/src/+/96a2fff4fa3bad98ba23052a08284f5c45e2d4e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M components/spellcheck/browser/feedback_sender.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/spellcheck/browser/feedback_sender.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M components/spellcheck/renderer/spellcheck.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_mac_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Will Harris
3 years, 10 months ago (2017-02-06 20:53:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96a2fff4fa3bad98ba23052a08284f5c45e2d4e4.

Powered by Google App Engine
This is Rietveld 408576698