Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2680563002: Revert of Remove ScopedVector in components/spellcheck (Closed)

Created:
3 years, 10 months ago by Will Harris
Modified:
3 years, 10 months ago
Reviewers:
groby-ooo-7-16, ke.he
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove ScopedVector in components/spellcheck (patchset #5 id:80001 of https://codereview.chromium.org/2658013002/ ) Reason for revert: causing crashes on canary see crbug.com/688770 Original issue's description: > Remove ScopedVector in components/spellcheck > > BUG=554289 > > Review-Url: https://codereview.chromium.org/2658013002 > Cr-Commit-Position: refs/heads/master@{#447961} > Committed: https://chromium.googlesource.com/chromium/src/+/293806358ee234776a9f73f05fdb08a3e3e7e78a TBR=groby@chromium.org,ke.he@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=554289, 688770 Review-Url: https://codereview.chromium.org/2680563002 Cr-Commit-Position: refs/heads/master@{#448346} Committed: https://chromium.googlesource.com/chromium/src/+/17ae25764e3d827b1fe4b1671734811d877839f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M components/spellcheck/browser/feedback_sender.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/spellcheck/browser/feedback_sender.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M components/spellcheck/renderer/spellcheck.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_mac_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Will Harris
Created Revert of Remove ScopedVector in components/spellcheck
3 years, 10 months ago (2017-02-06 18:18:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680563002/1
3 years, 10 months ago (2017-02-06 18:18:27 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:24:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17ae25764e3d827b1fe4b1671734...

Powered by Google App Engine
This is Rietveld 408576698