Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2670973002: Update V8 to version 5.8.111. (Closed)

Created:
3 years, 10 months ago by v8-autoroll
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Yang, joedow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 5.8.111. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5dd3abff..6ea247d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2670973002 Cr-Commit-Position: refs/heads/master@{#447980} Committed: https://chromium.googlesource.com/chromium/src/+/49e97227eb3b54d9721c27a37a162dc84355d13f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
v8-autoroll
3 years, 10 months ago (2017-02-03 09:02:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670973002/1
3 years, 10 months ago (2017-02-03 09:02:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/49e97227eb3b54d9721c27a37a162dc84355d13f
3 years, 10 months ago (2017-02-03 12:09:33 UTC) #6
joedow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2673953002/ by joedow@chromium.org. ...
3 years, 10 months ago (2017-02-03 20:11:28 UTC) #7
Michael Achenbach
CC kozyatinskiy, yangguo to help figuring our which inspector CL caused the leaks. Range: https://chromium.googlesource.com/v8/v8/+log/5dd3abff..6ea247d1
3 years, 10 months ago (2017-02-04 11:56:51 UTC) #8
Michael Achenbach
@joedow: Is it practice to revert rolls because of non-CQ bots? Maybe my knowledge is ...
3 years, 10 months ago (2017-02-04 12:06:52 UTC) #9
kozy
On 2017/02/04 11:56:51, Michael Achenbach wrote: > CC kozyatinskiy, yangguo to help figuring our which ...
3 years, 10 months ago (2017-02-04 17:08:43 UTC) #10
kozy
On 2017/02/04 17:08:43, kozy wrote: > On 2017/02/04 11:56:51, Michael Achenbach wrote: > > CC ...
3 years, 10 months ago (2017-02-04 17:31:54 UTC) #11
Michael Achenbach
On 2017/02/04 17:31:54, kozy wrote: > On 2017/02/04 17:08:43, kozy wrote: > > On 2017/02/04 ...
3 years, 10 months ago (2017-02-06 08:01:27 UTC) #12
joedow
machenbach@, I was going to add an entry into LeakExpectations here: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/LeakExpectations. However the text ...
3 years, 10 months ago (2017-02-06 17:05:36 UTC) #14
Michael Achenbach
3 years, 10 months ago (2017-02-06 18:21:49 UTC) #15
Message was sent while issue was closed.
On 2017/02/06 17:05:36, joedow wrote:
> machenbach@, I was going to add an entry into LeakExpectations here:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/LeakExpec....
> 
> However the text in the file said to revert the CL instead of adding an
> override.  I interpreted that reverting the auto-roll until the issue was
fixed.
>  I can add an exception next time if that is preferred.
> 
> Joe

Fair enough. Next time, probably somebody else is sheriff :/

@hablich: lets discuss offline if we can either get the comment in the
expectation file updated for auto-rollers or add the trybot to our additional
trybot list. The latter would require adding some extra slaves to the bot...

Or we wait until next time. This was the first time a layout-test leak hit a V8
roll.

Powered by Google App Engine
This is Rietveld 408576698