[stubs] Also port the CallICStub to CSA.

[stubs] Also port the CallICStub to CSA.

Port the Call feedback machinery from the interpreter to the CallICStub
as second step to unify the feedback collection. This removes a lot of
hand-written native code, and makes the runtime miss handler obsolete.
The next step will be to use the CallICStub from the interpreter as
well.

Drive-by-fix: Adjust CallIC/CallICTrampoline descriptors names.

R=mvstanton@chromium.org
BUG=v8:5049
Review-Url: https://codereview.chromium.org/2670843002
Cr-Commit-Position: refs/heads/master@{#42889}
Committed: https://chromium.googlesource.com/v8/v8/+/d68dfe861931fb9614700ba195a304deaa499021

[Benedikt Meurer, 2017-02-02 12:22:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 12:22:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-02-02 12:33:52]

LGTM, one small issue to address.
Bye-bye platform code!

https://codereview.chromium.org/2670843002/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/2670843002/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:1819: __ Move(edx,
Immediate(SmiFromSlot(expr->CallFeedbackICSlot())->value()));
As we discussed, make an IntFromSlot(slot) helper so the intention is clear.
(For the short period of time this code lives :)).

[Benedikt Meurer, 2017-02-02 12:36:40]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 12:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-02-02 12:37:11]

https://codereview.chromium.org/2670843002/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/2670843002/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:1819: __ Move(edx,
Immediate(SmiFromSlot(expr->CallFeedbackICSlot())->value()));
On 2017/02/02 12:33:52, mvstanton wrote:
> As we discussed, make an IntFromSlot(slot) helper so the intention is clear.
> (For the short period of time this code lives :)).

Done.

[Benedikt Meurer, 2017-02-02 12:37:16]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-02 12:37:21]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-02 12:37:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2670843002/#ps20001
(title: "Introduce FullCodeGenerator::IntFromSlot.")

[commit-bot: I haz the power, 2017-02-02 12:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-02-02 12:49:36]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-02 12:49:39]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-02-02 12:49:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 13:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486039779961130,
"parent_rev": "c126d604c93d29336c694de4cc8c96df6e74f7f8", "commit_rev":
"d68dfe861931fb9614700ba195a304deaa499021"}

[commit-bot: I haz the power, 2017-02-02 13:29:42]

Description was changed from

==========
[stubs] Also port the CallICStub to CSA.

Port the Call feedback machinery from the interpreter to the CallICStub
as second step to unify the feedback collection. This removes a lot of
hand-written native code, and makes the runtime miss handler obsolete.
The next step will be to use the CallICStub from the interpreter as
well.

Drive-by-fix: Adjust CallIC/CallICTrampoline descriptors names.

R=mvstanton@chromium.org
BUG=v8:5049
==========

to

==========
[stubs] Also port the CallICStub to CSA.

Port the Call feedback machinery from the interpreter to the CallICStub
as second step to unify the feedback collection. This removes a lot of
hand-written native code, and makes the runtime miss handler obsolete.
The next step will be to use the CallICStub from the interpreter as
well.

Drive-by-fix: Adjust CallIC/CallICTrampoline descriptors names.

R=mvstanton@chromium.org
BUG=v8:5049

Review-Url: https://codereview.chromium.org/2670843002
Cr-Commit-Position: refs/heads/master@{#42889}
Committed:
https://chromium.googlesource.com/v8/v8/+/d68dfe861931fb9614700ba195a304deaa4...
==========

[commit-bot: I haz the power, 2017-02-02 13:29:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d68dfe861931fb9614700ba195a304deaa4...