Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2669193002: [stubs] Remove obsolete CALL_IC code kind. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove obsolete CALL_IC code kind. We don't need Code::CALL_IC for anything now that the CallICStub is migrated and no longer hooks into the traditional IC system. R=yangguo@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2669193002 Cr-Commit-Position: refs/heads/master@{#42890} Committed: https://chromium.googlesource.com/v8/v8/+/2baea747deb491d983cfac3e81b2744bc3de1cc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -29 lines) Patch
M src/code-stubs.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/ic/ic.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/log.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +1 line, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-02 13:01:09 UTC) #1
Yang
On 2017/02/02 13:01:09, Benedikt Meurer wrote: lgtm.
3 years, 10 months ago (2017-02-02 13:02:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669193002/1
3 years, 10 months ago (2017-02-02 13:31:21 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 13:33:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2baea747deb491d983cfac3e81b2744bc3d...

Powered by Google App Engine
This is Rietveld 408576698