Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2670833003: [NTP] Rephrase the comment in components/ntp_snippets/OWNERS. (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
Marc Treib, sfiera
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Rephrase the comment in components/ntp_snippets/OWNERS. Rephrase the comment from "backup OWNERS" to "ordinary OWNERS for inside-team CLs". BUG=None Review-Url: https://codereview.chromium.org/2670833003 Cr-Commit-Position: refs/heads/master@{#447971} Committed: https://chromium.googlesource.com/chromium/src/+/6fb1a6ff9319dbf7e9dd8d165f675ed398160db2

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M components/ntp_snippets/OWNERS View 1 chunk +4 lines, -5 lines 3 comments Download

Messages

Total messages: 16 (9 generated)
vitaliii
[small change] Hi treib@, PTAL.
3 years, 10 months ago (2017-02-02 14:23:28 UTC) #4
Marc Treib
lgtm https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS File components/ntp_snippets/OWNERS (right): https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS#newcode5 components/ntp_snippets/OWNERS:5: # Unsure who to ask? Choose from the ...
3 years, 10 months ago (2017-02-02 14:27:31 UTC) #5
vitaliii
Hi sfiera@, Do you know a better way to achieve what I am trying to ...
3 years, 10 months ago (2017-02-02 14:30:47 UTC) #7
sfiera
https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS File components/ntp_snippets/OWNERS (right): https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS#newcode5 components/ntp_snippets/OWNERS:5: # Unsure who to ask? Choose from the above. ...
3 years, 10 months ago (2017-02-02 14:41:07 UTC) #10
vitaliii
I answered sfiera@ comment, no need to look. https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS File components/ntp_snippets/OWNERS (right): https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS#newcode5 components/ntp_snippets/OWNERS:5: # ...
3 years, 10 months ago (2017-02-03 08:59:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670833003/1
3 years, 10 months ago (2017-02-03 08:59:29 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 09:32:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fb1a6ff9319dbf7e9dd8d165f67...

Powered by Google App Engine
This is Rietveld 408576698