|
|
Chromium Code Reviews
Description[NTP] Rephrase the comment in components/ntp_snippets/OWNERS.
Rephrase the comment from "backup OWNERS" to "ordinary OWNERS for
inside-team CLs".
BUG=None
Review-Url: https://codereview.chromium.org/2670833003
Cr-Commit-Position: refs/heads/master@{#447971}
Committed: https://chromium.googlesource.com/chromium/src/+/6fb1a6ff9319dbf7e9dd8d165f675ed398160db2
Patch Set 1 #
Total comments: 3
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vitaliii@chromium.org changed reviewers: + treib@chromium.org
[small change] Hi treib@, PTAL.
lgtm https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS File components/ntp_snippets/OWNERS (right): https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWN... components/ntp_snippets/OWNERS:5: # Unsure who to ask? Choose from the above. nitty nit: It's kinda weird that this comment is attached to this block, but really concerns the above one. Not sure how to formulate it better though.
vitaliii@chromium.org changed reviewers: + sfiera@chromium.org
Hi sfiera@, Do you know a better way to achieve what I am trying to do? :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS File components/ntp_snippets/OWNERS (right): https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWN... components/ntp_snippets/OWNERS:5: # Unsure who to ask? Choose from the above. On 2017/02/02 14:27:31, Marc Treib wrote: > nitty nit: It's kinda weird that this comment is attached to this block, but > really concerns the above one. Not sure how to formulate it better though. I think that `git cl owners` will show you a comment that's after the username it suggests. So, I think a more useful way of formatting the file would be: bauerb@chromium.org # primary owner vitaliii@chromium.org # secondary owner, primary for offline noyau@chromium.org # ios owner so that someone that runs the command will have a good idea whether to accept the suggestion or hold out for another.
I answered sfiera@ comment, no need to look. https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWNERS File components/ntp_snippets/OWNERS (right): https://codereview.chromium.org/2670833003/diff/1/components/ntp_snippets/OWN... components/ntp_snippets/OWNERS:5: # Unsure who to ask? Choose from the above. On 2017/02/02 14:41:07, sfiera wrote: > On 2017/02/02 14:27:31, Marc Treib wrote: > > nitty nit: It's kinda weird that this comment is attached to this block, but > > really concerns the above one. Not sure how to formulate it better though. > > I think that `git cl owners` will show you a comment that's after the username > it suggests. So, I think a more useful way of formatting the file would be: > > mailto:bauerb@chromium.org # primary owner > mailto:vitaliii@chromium.org # secondary owner, primary for offline > mailto:noyau@chromium.org # ios owner > > so that someone that runs the command will have a good idea whether to accept > the suggestion or hold out for another. I see your point. However, previously we had no end line comments for a very long time and I do not recall getting random CLs to review. Thus, I assume that suggested usage is rather unlikely. Let's try as it is in this CL and if we start getting random CLs, then move to your approach.
The CQ bit was checked by vitaliii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486112355198710, "parent_rev":
"202f1212a29d67d81515dfa55f31b0ec8501efb3", "commit_rev":
"6fb1a6ff9319dbf7e9dd8d165f675ed398160db2"}
Message was sent while issue was closed.
Description was changed from ========== [NTP] Rephrase the comment in components/ntp_snippets/OWNERS. Rephrase the comment from "backup OWNERS" to "ordinary OWNERS for inside-team CLs". BUG=None ========== to ========== [NTP] Rephrase the comment in components/ntp_snippets/OWNERS. Rephrase the comment from "backup OWNERS" to "ordinary OWNERS for inside-team CLs". BUG=None Review-Url: https://codereview.chromium.org/2670833003 Cr-Commit-Position: refs/heads/master@{#447971} Committed: https://chromium.googlesource.com/chromium/src/+/6fb1a6ff9319dbf7e9dd8d165f67... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6fb1a6ff9319dbf7e9dd8d165f67... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
