components/ntp_snippets/OWNERS - Issue 2670833003: [NTP] Rephrase the comment in components/ntp_snippets/OWNERS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/OWNERS

Issue 2670833003: [NTP] Rephrase the comment in components/ntp_snippets/OWNERS. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Main owners:

2 bauerb@chromium.org	1 bauerb@chromium.org

3 jkrcal@chromium.org	2 jkrcal@chromium.org

4 treib@chromium.org	3 treib@chromium.org

5	4

	5 # Unsure who to ask? Choose from the above.
	Marc Treib 2017/02/02 14:27:31 nitty nit: It's kinda weird that this comment is a nitty nit: It's kinda weird that this comment is attached to this block, but really concerns the above one. Not sure how to formulate it better though. sfiera 2017/02/02 14:41:07 I think that `git cl owners` will show you a comme Show quoted text On 2017/02/02 14:27:31, Marc Treib wrote: > nitty nit: It's kinda weird that this comment is attached to this block, but > really concerns the above one. Not sure how to formulate it better though. I think that `git cl owners` will show you a comment that's after the username it suggests. So, I think a more useful way of formatting the file would be: bauerb@chromium.org # primary owner vitaliii@chromium.org # secondary owner, primary for offline noyau@chromium.org # ios owner so that someone that runs the command will have a good idea whether to accept the suggestion or hold out for another. vitaliii 2017/02/03 08:59:04 I see your point. However, previously we had no en Show quoted text On 2017/02/02 14:41:07, sfiera wrote: > On 2017/02/02 14:27:31, Marc Treib wrote: > > nitty nit: It's kinda weird that this comment is attached to this block, but > > really concerns the above one. Not sure how to formulate it better though. > > I think that `git cl owners` will show you a comment that's after the username > it suggests. So, I think a more useful way of formatting the file would be: > > mailto:bauerb@chromium.org # primary owner > mailto:vitaliii@chromium.org # secondary owner, primary for offline > mailto:noyau@chromium.org # ios owner > > so that someone that runs the command will have a good idea whether to accept > the suggestion or hold out for another. I see your point. However, previously we had no end line comments for a very long time and I do not recall getting random CLs to review. Thus, I assume that suggested usage is rather unlikely. Let's try as it is in this CL and if we start getting random CLs, then move to your approach.
	6 markusheintz@chromium.org

	7 vitaliii@chromium.org

	8

6 # For ios:	9 # For ios:

7 noyau@chromium.org	10 noyau@chromium.org

8

9 # Fallback, in case all of the above are OOO:

10 markusheintz@chromium.org

11 vitaliii@chromium.org

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »