Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.mm

Issue 2670743002: Track renderer crash detected on WebState via GlobalWebStateObserver (Closed)
Patch Set: comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc ('k') | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.mm
diff --git a/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc b/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.mm
similarity index 83%
rename from ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc
rename to ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.mm
index c7c22b02185ba7cd2a8158ac8fb5c14218a6d10d..09db12b58497970358beebce1edc93df2ef7e488 100644
--- a/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc
+++ b/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.mm
@@ -4,6 +4,8 @@
#include "ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.h"
+#import "ios/web/public/web_state/web_state.h"
+
IOSChromeStabilityMetricsProvider::IOSChromeStabilityMetricsProvider(
PrefService* local_state)
: helper_(local_state), recording_enabled_(false) {}
@@ -47,3 +49,12 @@ void IOSChromeStabilityMetricsProvider::WebStateDidStartLoading(
helper_.LogLoadStarted();
}
+
+void IOSChromeStabilityMetricsProvider::RenderProcessGone(
Eugene But (OOO till 7-30) 2017/03/27 16:56:26 I gave some more thoughts about the problem, so so
pkl (ping after 24h if needed) 2017/04/13 22:29:40 Let's discuss this in person.
pkl (ping after 24h if needed) 2017/04/14 21:38:53 Discussed offline with eugenebut@. This CL should
+ web::WebState* web_state) {
+ if (!recording_enabled_)
+ return;
+ LogRendererCrash();
+ // TODO(crbug.com/685649): web_state->GetLastCommittedURL() is likely the URL
+ // that caused a renderer crash and can be logged here.
+}
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc ('k') | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698