ios/chrome/browser/tabs/tab.mm - Issue 2670743002: Track renderer crash detected on WebState via GlobalWebStateObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2670743002: Track renderer crash detected on WebState via GlobalWebStateObserver (Closed)

Patch Set: comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab.mm

diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm

index b5e12d3765c2add415dff86d912e2a3beaf136a6..93283b9a9c17f6461d1f62f5987fc118966d0718 100644

--- a/ios/chrome/browser/tabs/tab.mm

+++ b/ios/chrome/browser/tabs/tab.mm

@@ -1904,11 +1904,6 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,

- (void)renderProcessGoneForWebState:(web::WebState*)webState {

if (browserState_ && !browserState_->IsOffTheRecord()) {

- // Report the crash.

- GetApplicationContext()

- ->GetMetricsServicesManager()

- ->OnRendererProcessCrash();

// Log the tab state for the termination.

RendererTerminationTabState tab_state =

visible_ ? RendererTerminationTabState::FOREGROUND_TAB_FOREGROUND_APP