Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc

Issue 2670743002: Track renderer crash detected on WebState via GlobalWebStateObserver (Closed)
Patch Set: comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc
diff --git a/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc b/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc
deleted file mode 100644
index c7c22b02185ba7cd2a8158ac8fb5c14218a6d10d..0000000000000000000000000000000000000000
--- a/ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.h"
-
-IOSChromeStabilityMetricsProvider::IOSChromeStabilityMetricsProvider(
- PrefService* local_state)
- : helper_(local_state), recording_enabled_(false) {}
-
-IOSChromeStabilityMetricsProvider::~IOSChromeStabilityMetricsProvider() {}
-
-void IOSChromeStabilityMetricsProvider::OnRecordingEnabled() {
- recording_enabled_ = true;
-}
-
-void IOSChromeStabilityMetricsProvider::OnRecordingDisabled() {
- recording_enabled_ = false;
-}
-
-void IOSChromeStabilityMetricsProvider::ProvideStabilityMetrics(
- metrics::SystemProfileProto* system_profile_proto) {
- helper_.ProvideStabilityMetrics(system_profile_proto);
-}
-
-void IOSChromeStabilityMetricsProvider::ClearSavedStabilityMetrics() {
- helper_.ClearSavedStabilityMetrics();
-}
-
-void IOSChromeStabilityMetricsProvider::LogRendererCrash() {
- if (!recording_enabled_)
- return;
-
- // The actual termination code isn't provided on iOS; use a dummy value.
- // TODO(blundell): Think about having StabilityMetricsHelper have a variant
- // that doesn't supply these arguments to make this cleaner.
- int dummy_termination_code = 105;
- helper_.LogRendererCrash(false /* not an extension process */,
- base::TERMINATION_STATUS_ABNORMAL_TERMINATION,
- dummy_termination_code);
-}
-
-void IOSChromeStabilityMetricsProvider::WebStateDidStartLoading(
- web::WebState* web_state) {
- if (!recording_enabled_)
- return;
-
- helper_.LogLoadStarted();
-}

Powered by Google App Engine
This is Rietveld 408576698