Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2670623003: Speculative fixes for search engine crashes. (Closed)

Created:
3 years, 10 months ago by Ted C
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Speculative fixes for search engine crashes. 1.) We were not listening for changes from the template URL service, which seems more likely to happen with custom engine support. 2.) We were setting the search engine on initialization and "maybe" that changed the underlying data so some keywords were dropped. BUG=670250 Review-Url: https://codereview.chromium.org/2655333003 Cr-Commit-Position: refs/heads/master@{#446866} (cherry picked from commit ea757161c1067010f73c9ab922d867a6648b202f) Review-Url: https://codereview.chromium.org/2670623003 . Cr-Commit-Position: refs/branch-heads/2987@{#257} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ffc47f4bf55761edb7c15260d8a3fa6416d53715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java View 7 chunks +67 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 10 months ago (2017-02-01 23:57:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ffc47f4bf55761edb7c15260d8a3fa6416d53715.

Powered by Google App Engine
This is Rietveld 408576698