Speculative fixes for search engine crashes.

Speculative fixes for search engine crashes.

1.) We were not listening for changes from the template
    URL service, which seems more likely to happen with
    custom engine support.
2.) We were setting the search engine on initialization and
    "maybe" that changed the underlying data so some keywords
    were dropped.

BUG=670250
Review-Url: https://codereview.chromium.org/2655333003
Cr-Commit-Position: refs/heads/master@{#446866}
Committed: https://chromium.googlesource.com/chromium/src/+/ea757161c1067010f73c9ab922d867a6648b202f

[Ted C, 2017-01-27 17:42:42]

tedchoc@chromium.org changed reviewers:
+ ianwen@chromium.org, twellington@chromium.org

[Ted C, 2017-01-27 17:42:43]

PTAL

[Theresa, 2017-01-27 23:25:44]

lgtm % nits

https://codereview.chromium.org/2655333003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/2655333003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:168:
mInitialEnginePosition = -1;
Since this is set below, on line 192, does setting it to -1 do anything?

https://codereview.chromium.org/2655333003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:173:
mSelectedSearchEnginePosition = -1;
nit: this is a no-op since line 167 sets it to -1 as well.

[Ted C, 2017-01-28 00:01:30]

https://codereview.chromium.org/2655333003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/2655333003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:168:
mInitialEnginePosition = -1;
On 2017/01/27 23:25:44, Theresa wrote:
> Since this is set below, on line 192, does setting it to -1 do anything?

Nah, not needed...removed.  Used to reset all the variables at the top but it
has now changed.

https://codereview.chromium.org/2655333003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:173:
mSelectedSearchEnginePosition = -1;
On 2017/01/27 23:25:43, Theresa wrote:
> nit: this is a no-op since line 167 sets it to -1 as well.

now that I removed above, this is now the only line that remains

[Ted C, 2017-01-28 00:01:35]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-01-28 00:01:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2655333003/#ps20001
(title: "address twellington@ comments")

[commit-bot: I haz the power, 2017-01-28 00:02:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:16:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485561695297360,
"parent_rev": "5e465202abc260c9aa8319f8e77bf721e0453ed2", "commit_rev":
"ea757161c1067010f73c9ab922d867a6648b202f"}

[commit-bot: I haz the power, 2017-01-28 01:17:38]

Description was changed from

==========
Speculative fixes for search engine crashes.

1.) We were not listening for changes from the template
    URL service, which seems more likely to happen with
    custom engine support.
2.) We were setting the search engine on initialization and
    "maybe" that changed the underlying data so some keywords
    were dropped.

BUG=670250
==========

to

==========
Speculative fixes for search engine crashes.

1.) We were not listening for changes from the template
    URL service, which seems more likely to happen with
    custom engine support.
2.) We were setting the search engine on initialization and
    "maybe" that changed the underlying data so some keywords
    were dropped.

BUG=670250

Review-Url: https://codereview.chromium.org/2655333003
Cr-Commit-Position: refs/heads/master@{#446866}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea757161c1067010f73c9ab922d8...
==========

[commit-bot: I haz the power, 2017-01-28 01:17:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea757161c1067010f73c9ab922d8...