Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2670573002: Revert of Replace IPC messages in layout_test_render_frame_observer. (Closed)

Created:
3 years, 10 months ago by Łukasz Anforowicz
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace IPC messages in layout_test_render_frame_observer. (patchset #17 id:330001 of https://codereview.chromium.org/2594913002/ ) Reason for revert: This CL breaks linux_site_isolation trybot required by the CQ for some CLs - let's try to revert. See https://crbug.com/687353 for more information. Original issue's description: > Replace IPC messages in layout_test_render_frame_observer. > > Also remove some forward declarations that are becoming useless. > > BUG=577685 > > Review-Url: https://codereview.chromium.org/2594913002 > Cr-Commit-Position: refs/heads/master@{#446952} > Committed: https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea52b1c67a1fa1 TBR=mkwst@chromium.org,jam@chromium.org,sammc@chromium.org,tibell@chromium.org,jiameng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=577685 Review-Url: https://codereview.chromium.org/2670573002 Cr-Commit-Position: refs/heads/master@{#447594} Committed: https://chromium.googlesource.com/chromium/src/+/7b4b3bfebbb99287415c516f8792b9e9c9bc3436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -160 lines) Patch
M content/shell/BUILD.gn View 2 chunks +3 lines, -7 lines 0 comments Download
M content/shell/browser/content_shell_renderer_manifest_overlay.json View 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 6 chunks +16 lines, -37 lines 0 comments Download
M content/shell/common/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D content/shell/common/layout_test.mojom View 1 chunk +0 lines, -50 lines 0 comments Download
M content/shell/common/shell_messages.h View 3 chunks +28 lines, -0 lines 0 comments Download
A content/shell/common/shell_test_configuration.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/shell/common/shell_test_configuration.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.h View 1 chunk +16 lines, -12 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.cc View 3 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Łukasz Anforowicz
Created Revert of Replace IPC messages in layout_test_render_frame_observer.
3 years, 10 months ago (2017-02-01 18:26:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670573002/1
3 years, 10 months ago (2017-02-01 18:26:56 UTC) #3
tibell
lgtm
3 years, 10 months ago (2017-02-01 18:31:57 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:21:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b4b3bfebbb99287415c516f8792...

Powered by Google App Engine
This is Rietveld 408576698