Replace IPC messages in layout_test_render_frame_observer.

Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG=577685
Review-Url: https://codereview.chromium.org/2594913002
Cr-Original-Commit-Position: refs/heads/master@{#446952}
Committed: https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea52b1c67a1fa1
Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#448846}
Committed: https://chromium.googlesource.com/chromium/src/+/d518643748bffd4d67c504a5181489ab75b89a1d

[Jia, 2016-12-21 03:18:43]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 03:19:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:23:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:23:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2016-12-22 02:24:22]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[Jia, 2016-12-22 02:24:23]

The CQ bit was unchecked by jiameng@chromium.org

[Jia, 2016-12-22 02:24:40]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 02:24:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:46:40]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Jia, 2016-12-22 03:14:06]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 03:14:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 03:44:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 03:44:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Jia, 2017-01-02 23:04:28]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 23:04:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 23:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 23:49:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-04 00:45:34]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 02:06:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jia, 2017-01-05 04:29:22]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 04:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 04:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 04:33:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-05 05:21:25]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 05:21:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 05:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 05:26:16]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-10 03:31:14]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 03:32:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:37:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jia, 2017-01-10 04:02:16]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 04:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 04:07:40]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jia, 2017-01-10 04:24:57]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 04:25:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 04:30:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Jia, 2017-01-10 04:50:00]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 04:50:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:13:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jia, 2017-01-11 06:03:31]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:03:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:07:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:07:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-17 22:52:52]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 22:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:59:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-18 04:43:27]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 04:43:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 06:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 06:25:34]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-01-18 22:50:33]

Description was changed from

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685
==========

to

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685
==========

[Jia, 2017-01-18 22:50:33]

jiameng@chromium.org changed reviewers:
+ sammc@chromium.org, tibell@chromium.org

[Jia, 2017-01-18 22:59:37]

Hi Sam, Johan,

Here is my cl, please review when you have time.

Thanks!
Jia

[tibell, 2017-01-19 00:29:54]

Thanks for migrating this! Just some small comments.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.h:219: const
mojom::ShellViewAssociatedPtr& GetShellViewPtr(RenderFrameHost* frame);
This could probably return a mojom::ShellView* instead (just call get() on the
AssociatedPtr). Won't change anything on the caller side, but hides some
implementation details.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell.mojom (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.mojom:11: LayoutDumpRequest();
Could you copy over the comments from the messages.h file here as documentation?

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell_param_traits.h (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell_param_traits.h:12:
IPC_STRUCT_TRAITS_MEMBER(current_working_directory)
The IPC_STRUCT_TRAITS_MEMBER calls are usually indented 2 spaces.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/t...
File content/shell/common/typemaps.gni (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/t...
content/shell/common/typemaps.gni:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
It's 2017, happy new year! :)

https://codereview.chromium.org/2594913002/diff/180001/content/shell/renderer...
File content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
(right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/renderer...
content/shell/renderer/layout_test/layout_test_render_frame_observer.cc:34:
LayoutTestRenderFrameObserver::~LayoutTestRenderFrameObserver() {}
Nit: I believe

LayoutTestRenderFrameObserver::~LayoutTestRenderFrameObserver() = default;

works.

[Jia, 2017-01-19 04:46:40]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 04:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 05:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 05:03:09]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-19 05:28:48]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 05:29:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-19 05:41:35]

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
File content/shell/browser/content_shell_renderer_manifest_overlay.json (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
content/shell/browser/content_shell_renderer_manifest_overlay.json:17:
"requires": {
I don't think this requires section is necessary.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell.mojom (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.mojom:10: interface ShellView {
I think this should be named something like "LayoutTestControl".

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell.typemap (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.typemap:9: "//content/public/common",
This should be in public_deps instead.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.typemap:10: "//ipc:ipc",
"//ipc"

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.typemap:11: "//ui/gfx/ipc:ipc",
"//ui/gfx/ipc"

[commit-bot: I haz the power, 2017-01-19 07:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:02:29]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-01-19 23:31:16]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 23:31:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:30:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:30:51]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-01-20 01:52:15]

Thanks Johan, Sam! I've made the changes, PTAL.
Thanks,
Jia

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
File content/shell/browser/content_shell_renderer_manifest_overlay.json (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
content/shell/browser/content_shell_renderer_manifest_overlay.json:17:
"requires": {
On 2017/01/19 05:41:35, Sam McNally wrote:
> I don't think this requires section is necessary.

Done.When would we need "requires" section?

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.h:219: const
mojom::ShellViewAssociatedPtr& GetShellViewPtr(RenderFrameHost* frame);
On 2017/01/19 00:29:54, tibell wrote:
> This could probably return a mojom::ShellView* instead (just call get() on the
> AssociatedPtr). Won't change anything on the caller side, but hides some
> implementation details.

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell.mojom (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.mojom:10: interface ShellView {
On 2017/01/19 05:41:35, Sam McNally wrote:
> I think this should be named something like "LayoutTestControl".

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.mojom:11: LayoutDumpRequest();
On 2017/01/19 00:29:54, tibell wrote:
> Could you copy over the comments from the messages.h file here as
documentation?

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell.typemap (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.typemap:9: "//content/public/common",
On 2017/01/19 05:41:35, Sam McNally wrote:
> This should be in public_deps instead.

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.typemap:10: "//ipc:ipc",
On 2017/01/19 05:41:35, Sam McNally wrote:
> "//ipc"

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell.typemap:11: "//ui/gfx/ipc:ipc",
On 2017/01/19 05:41:35, Sam McNally wrote:
> "//ui/gfx/ipc"

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
File content/shell/common/shell_param_traits.h (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/s...
content/shell/common/shell_param_traits.h:12:
IPC_STRUCT_TRAITS_MEMBER(current_working_directory)
On 2017/01/19 00:29:54, tibell wrote:
> The IPC_STRUCT_TRAITS_MEMBER calls are usually indented 2 spaces.

Done.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/t...
File content/shell/common/typemaps.gni (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/common/t...
content/shell/common/typemaps.gni:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
On 2017/01/19 00:29:54, tibell wrote:
> It's 2017, happy new year! :)

Done. I started this cl in 2016, wow, it's been over a year :) I've changed all
other new files too.

https://codereview.chromium.org/2594913002/diff/180001/content/shell/renderer...
File content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
(right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/renderer...
content/shell/renderer/layout_test/layout_test_render_frame_observer.cc:34:
LayoutTestRenderFrameObserver::~LayoutTestRenderFrameObserver() {}
On 2017/01/19 00:29:54, tibell wrote:
> Nit: I believe
> 
> LayoutTestRenderFrameObserver::~LayoutTestRenderFrameObserver() = default;
> 
> works.

Done.

[tibell, 2017-01-20 01:55:19]

lgtm

https://codereview.chromium.org/2594913002/diff/230001/content/shell/common/l...
File content/shell/common/layout_test.mojom (right):

https://codereview.chromium.org/2594913002/diff/230001/content/shell/common/l...
content/shell/common/layout_test.mojom:11: // Asks a frame to dump its contents
into a string and send them back over IPC.
<80 chars

You can try to run "git cl format" and see if it detects any other style issues
(although I don't think it yet works on mojom files).

[Sam McNally, 2017-01-20 02:01:27]

lgtm

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
File content/shell/browser/content_shell_renderer_manifest_overlay.json (right):

https://codereview.chromium.org/2594913002/diff/180001/content/shell/browser/...
content/shell/browser/content_shell_renderer_manifest_overlay.json:17:
"requires": {
On 2017/01/20 01:52:14, Jia wrote:
> On 2017/01/19 05:41:35, Sam McNally wrote:
> > I don't think this requires section is necessary.
> 
> Done.When would we need "requires" section?

In this overlay, it would be necessary if the renderer needed to talk to another
service, but only in layout tests. The base manifest.json file that this overlay
over includes this part so it isn't necessary here.

[Jia, 2017-01-20 02:52:13]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:52:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-01-20 02:54:32]

jiameng@chromium.org changed reviewers:
+ mkwst@chromium.org

[Jia, 2017-01-20 02:54:33]

mkwst@chromium.org: Please review changes in

https://codereview.chromium.org/2594913002/diff/230001/content/shell/common/l...
File content/shell/common/layout_test.mojom (right):

https://codereview.chromium.org/2594913002/diff/230001/content/shell/common/l...
content/shell/common/layout_test.mojom:11: // Asks a frame to dump its contents
into a string and send them back over IPC.
On 2017/01/20 01:55:18, tibell wrote:
> <80 chars
> 
> You can try to run "git cl format" and see if it detects any other style
issues
> (although I don't think it yet works on mojom files).

Done. It indeed doesn't work on mojoms yet, but I've run git-cl format to format
other files, thanks!

[Jia, 2017-01-20 02:57:14]

jiameng@chromium.org changed reviewers:
+ jam@chromium.org

[Jia, 2017-01-20 02:57:15]

jam@chromium.org: Please review changes in

[commit-bot: I haz the power, 2017-01-20 05:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:17:11]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-01-20 12:04:24]

LGTM.

https://codereview.chromium.org/2594913002/diff/250001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2594913002/diff/250001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:970: return
layout_test_control_map_[frame].get();
Nit: Maybe DCHECK that we end up with a pointer?

https://codereview.chromium.org/2594913002/diff/250001/content/shell/common/O...
File content/shell/common/OWNERS (right):

https://codereview.chromium.org/2594913002/diff/250001/content/shell/common/O...
content/shell/common/OWNERS:8: per-file
*_param_traits*.*=file://ipc/SECURITY_OWNERS
Thanks for remembering to add these! I would have forgotten. :)

[jam, 2017-01-20 16:00:13]

On 2017/01/20 02:57:15, Jia wrote:
> mailto:jam@chromium.org: Please review changes in

?

[jam, 2017-01-20 16:00:14]

On 2017/01/20 02:57:15, Jia wrote:
> mailto:jam@chromium.org: Please review changes in

?

[Jia, 2017-01-22 22:52:01]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 22:52:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 02:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 02:32:56]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-01-23 02:37:39]

Thanks for all the reviews!
Jia

https://codereview.chromium.org/2594913002/diff/250001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2594913002/diff/250001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:970: return
layout_test_control_map_[frame].get();
On 2017/01/20 12:04:24, Mike West (sloooooow) wrote:
> Nit: Maybe DCHECK that we end up with a pointer?

Done.

[Jia, 2017-01-23 02:54:50]

On 2017/01/20 16:00:14, jam wrote:
> On 2017/01/20 02:57:15, Jia wrote:
> > mailto:jam@chromium.org: Please review changes in
> 
> ?

Would you please review
"mojo/public/tools/bindings/chromium_bindings_configuration.gni"?
Thanks!
Jia

[jam, 2017-01-23 16:59:23]

On 2017/01/23 02:54:50, Jia wrote:
> On 2017/01/20 16:00:14, jam wrote:
> > On 2017/01/20 02:57:15, Jia wrote:
> > > mailto:jam@chromium.org: Please review changes in
> > 
> > ?
> 
> Would you please review
> "mojo/public/tools/bindings/chromium_bindings_configuration.gni"?
> Thanks!
> Jia

Why do we need a typemap for ShellTestConfig, instead of just converting it to a
mojo structure and using that everywhere?

[Jia, 2017-01-24 00:47:20]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:47:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 03:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:48:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jia, 2017-01-24 06:06:47]

Patchset #17 (id:310001) has been deleted

[Jia, 2017-01-24 06:08:59]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 06:09:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 07:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 07:30:48]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-01-24 09:36:14]

On 2017/01/23 16:59:23, jam wrote:
> On 2017/01/23 02:54:50, Jia wrote:
> > On 2017/01/20 16:00:14, jam wrote:
> > > On 2017/01/20 02:57:15, Jia wrote:
> > > > mailto:jam@chromium.org: Please review changes in
> > > 
> > > ?
> > 
> > Would you please review
> > "mojo/public/tools/bindings/chromium_bindings_configuration.gni"?
> > Thanks!
> > Jia
> 
> Why do we need a typemap for ShellTestConfig, instead of just converting it to
a
> mojo structure and using that everywhere?

Thanks, I've replaced the old struct by the new mojo struct. PTAL.
Jia

[Jia, 2017-01-25 07:28:05]

Hi jam,

Would you please review my cl?

Thanks!
Jia

[jam, 2017-01-26 00:08:29]

On 2017/01/25 07:28:05, Jia wrote:
> Hi jam,
> 
> Would you please review my cl?
> 
> Thanks!
> Jia

lgtm, sorry I missed the reply (feel free to IM me in the future)

[Sam McNally, 2017-01-26 23:24:09]

https://codereview.chromium.org/2594913002/diff/290001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.h (right):

https://codereview.chromium.org/2594913002/diff/290001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.h:176: void
OnSetTestConfiguration(const mojom::ShellTestConfigurationPtr& params);
Pass these by value.

[Jia, 2017-01-29 23:12:40]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 23:12:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-01-29 23:14:35]

Thanks jam, Sam. PTAL.
Best regards,
Jia

https://codereview.chromium.org/2594913002/diff/290001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.h (right):

https://codereview.chromium.org/2594913002/diff/290001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.h:176: void
OnSetTestConfiguration(const mojom::ShellTestConfigurationPtr& params);
On 2017/01/26 23:24:08, Sam McNally wrote:
> Pass these by value.

Done. I used const ref to avoid Clone in some operations, but if it's better to
avoid using pass-by-ref and if clone isn't too expensive (I guess it's
inexpensive here), then I'll use pass-by-value.

[Sam McNally, 2017-01-29 23:22:15]

lgtm

https://codereview.chromium.org/2594913002/diff/330001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2594913002/diff/330001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:975:
mojom::ShellTestConfigurationPtr local_params = params.Clone();
You only need to keep a local copy of params->initial_size, not all the params.

[Jia, 2017-01-29 23:26:39]

Thanks Sam! PTAL.
Best regards,
Jia

https://codereview.chromium.org/2594913002/diff/330001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2594913002/diff/330001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:975:
mojom::ShellTestConfigurationPtr local_params = params.Clone();
On 2017/01/29 23:22:14, Sam McNally wrote:
> You only need to keep a local copy of params->initial_size, not all the
params.

Thanks Sam. As the clone op isn't expensive, I'd like to keep the local clone in
case other params are used later.

[Sam McNally, 2017-01-29 23:28:19]

lgtm

[Jia, 2017-01-30 00:47:07]

Thanks everyone. Please let me know if anyone has any other comment. If not,
I'll submit the cl shortly.
Best regards,
Jia

[commit-bot: I haz the power, 2017-01-30 01:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 01:05:58]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-01-30 01:41:54]

The CQ bit was checked by jiameng@chromium.org

[Jia, 2017-01-30 01:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tibell@chromium.org,
mkwst@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2594913002/#ps330001
(title: "Replace const ref by value")

[commit-bot: I haz the power, 2017-01-30 01:42:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 01:45:40]

CQ is committing da patch.

Bot data: {"patchset_id": 330001, "attempt_start_ts": 1485740514060660,
"parent_rev": "a7f5cbbe7f704ea74d57b7413a7b10b7a1b68750", "commit_rev":
"165c6d9ac3870f1c12553eff57ea52b1c67a1fa1"}

[commit-bot: I haz the power, 2017-01-30 01:46:52]

Description was changed from

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685
==========

to

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
==========

[commit-bot: I haz the power, 2017-01-30 01:46:54]

Committed patchset #17 (id:330001) as
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...

[Łukasz Anforowicz, 2017-02-01 18:26:28]

A revert of this CL (patchset #17 id:330001) has been created in
https://codereview.chromium.org/2670573002/ by lukasza@chromium.org.

The reason for reverting is: This CL breaks linux_site_isolation trybot required
by the CQ for some CLs - let's try to revert.  See https://crbug.com/687353 for
more information..

[Jia, 2017-02-06 22:55:28]

Description was changed from

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
==========

to

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
==========

[Jia, 2017-02-06 22:59:45]

Description was changed from

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
==========

to

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
==========

[Jia, 2017-02-06 23:00:01]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 23:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-02-06 23:13:40]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 23:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-02-07 00:42:00]

It appears test controller did not properly clean up constructs storing mojo
pointers, and so closed pipes were reused in subsequent tests, which caused
site_isolation test to fail randomly. 

I've put in a patch to handle closed pipe connections. Please review again.

Thanks,
Jia

[tibell, 2017-02-07 00:50:50]

lgtm

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:981: LOG(INFO) <<
"BlinkTestController::HandleLayoutTestControlError";
Remove

[Jia, 2017-02-07 00:56:52]

Done, thanks!
Jia

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:981: LOG(INFO) <<
"BlinkTestController::HandleLayoutTestControlError";
On 2017/02/07 00:50:50, tibell wrote:
> Remove

Done.

[Jia, 2017-02-07 01:37:58]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 01:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-07 01:45:11]

lgtm

[Jia, 2017-02-07 01:47:26]

jiameng@chromium.org changed reviewers:
+ lukasza@chromium.org

[Jia, 2017-02-07 01:48:55]

Hi Lukasz,

I've put in a patch to resolve the site isolation issue. Please review.

Thanks!
Jia

[commit-bot: I haz the power, 2017-02-07 03:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 03:20:41]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-02-07 17:36:31]

LGTM (with a small nit below).  Thank you for fixing the OOPIF support.  Also -
thanks for starting to migrate layout tests to mojo.

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:612:
params->enable_pixel_dumping = true;
nit: The line above can be removed  - we always set the same field a few lines
below, right?

[Jia, 2017-02-07 22:08:37]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[Jia, 2017-02-07 22:09:31]

On 2017/02/07 17:36:31, Łukasz Anforowicz wrote:
> LGTM (with a small nit below).  Thank you for fixing the OOPIF support.  Also
-
> thanks for starting to migrate layout tests to mojo.
> 
>
https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
> File content/shell/browser/layout_test/blink_test_controller.cc (right):
> 
>
https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
> content/shell/browser/layout_test/blink_test_controller.cc:612:
> params->enable_pixel_dumping = true;
> nit: The line above can be removed  - we always set the same field a few lines
> below, right?

Thanks Lukasz! I've made the change, PTAL.
Thanks!
Jia

[commit-bot: I haz the power, 2017-02-07 22:09:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-02-07 22:10:17]

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:612:
params->enable_pixel_dumping = true;
On 2017/02/07 17:36:31, Łukasz Anforowicz wrote:
> nit: The line above can be removed  - we always set the same field a few lines
> below, right?

Done. Yes that's right. I put in here to "simulate" the constructor of the old
ShellConfiguration struct.

[Łukasz Anforowicz, 2017-02-07 22:16:23]

On 2017/02/07 22:10:17, Jia wrote:
>
https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
> File content/shell/browser/layout_test/blink_test_controller.cc (right):
> 
>
https://codereview.chromium.org/2594913002/diff/350001/content/shell/browser/...
> content/shell/browser/layout_test/blink_test_controller.cc:612:
> params->enable_pixel_dumping = true;
> On 2017/02/07 17:36:31, Łukasz Anforowicz wrote:
> > nit: The line above can be removed  - we always set the same field a few
lines
> > below, right?
> 
> Done. Yes that's right. I put in here to "simulate" the constructor of the old
> ShellConfiguration struct.

Thanks - LGTM.

[commit-bot: I haz the power, 2017-02-08 01:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:06:10]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-02-08 01:41:27]

The CQ bit was checked by jiameng@chromium.org

[Jia, 2017-02-08 01:41:27]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
jam@chromium.org, tibell@chromium.org, sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2594913002/#ps390001
(title: "Removed a redundant line")

[commit-bot: I haz the power, 2017-02-08 01:42:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:48:26]

CQ is committing da patch.

Bot data: {"patchset_id": 390001, "attempt_start_ts": 1486518087348790,
"parent_rev": "7ab4a9fbba49a459dbff5c4e888a4f4ab8923abb", "commit_rev":
"d518643748bffd4d67c504a5181489ab75b89a1d"}

[commit-bot: I haz the power, 2017-02-08 01:49:00]

Description was changed from

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
==========

to

==========
Replace IPC messages in layout_test_render_frame_observer.

Also remove some forward declarations that are becoming useless.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG=577685

Review-Url: https://codereview.chromium.org/2594913002
Cr-Original-Commit-Position: refs/heads/master@{#446952}
Committed:
https://chromium.googlesource.com/chromium/src/+/165c6d9ac3870f1c12553eff57ea...
Review-Url: https://codereview.chromium.org/2594913002
Cr-Commit-Position: refs/heads/master@{#448846}
Committed:
https://chromium.googlesource.com/chromium/src/+/d518643748bffd4d67c504a51814...
==========

[commit-bot: I haz the power, 2017-02-08 01:49:02]

Committed patchset #20 (id:390001) as
https://chromium.googlesource.com/chromium/src/+/d518643748bffd4d67c504a51814...