Only allow the desired child proc to inherit its output file.

Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implementation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2670213004
Cr-Commit-Position: refs/heads/master@{#447996}
Committed: https://chromium.googlesource.com/chromium/src/+/9ea51a5ffa60046859be210ca5a76ae85abf5a94

[grt (UTC plus 2), 2017-02-03 12:42:26]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 12:42:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-02-03 12:43:21]

Description was changed from

==========
Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implelentation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org
==========

to

==========
Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implelentation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org
==========

[grt (UTC plus 2), 2017-02-03 12:43:59]

PTAL

[Paweł Hajdan Jr., 2017-02-03 12:54:27]

LGTM . Thanks!

Consider making it more obvious in the comment that we rely on the lock so that
there's no window when the handle could be inherited by other processes.

[grt (UTC plus 2), 2017-02-03 13:00:10]

Description was changed from

==========
Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implelentation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org
==========

to

==========
Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implementation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org
==========

[grt (UTC plus 2), 2017-02-03 13:03:51]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-02-03 13:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2670213004/#ps20001
(title: "comment tweak")

[commit-bot: I haz the power, 2017-02-03 13:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 14:42:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486127031256840,
"parent_rev": "2d367b561d91f5f0c46724d66ea64852eadbb15a", "commit_rev":
"9ea51a5ffa60046859be210ca5a76ae85abf5a94"}

[commit-bot: I haz the power, 2017-02-03 14:43:06]

Description was changed from

==========
Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implementation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org
==========

to

==========
Only allow the desired child proc to inherit its output file.

Prior to this change, other children would end up with references to an
earlier child's stdout handle, thereby preventing it from being deleted.

This change alone makes things better, but doesn't entirely plug the
hole: OpenFile (used by ReadFileToString) inadvertently opens its
handles for inheritance due to implementation details of the Microsoft
CRT. There exists an undocumented "N" mode flag for opening file streams
that disables allowing the opened file to be inherited into child
processes. Another CL will address this.

BUG=671990
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2670213004
Cr-Commit-Position: refs/heads/master@{#447996}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ea51a5ffa60046859be210ca5a7...
==========

[commit-bot: I haz the power, 2017-02-03 14:43:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ea51a5ffa60046859be210ca5a7...