Only allow the desired child proc to inherit its output file.

base/test/launcher/test_launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/launcher/test_launcher.h"
 
 #include <memory>
 
 #include "base/at_exit.h"
 #include "base/bind.h"
@@ skipping 291 matching lines @@
 #endif
 
   Process process;
 
   {
     // Note how we grab the lock before the process possibly gets created.
     // This ensures that when the lock is held, ALL the processes are registered
     // in the set.
     AutoLock lock(g_live_processes_lock.Get());
 
+#if defined(OS_WIN)
+    // Allow the handle used to capture stdio and stdout to be inherited by the
+    // child. Note that this is done under g_live_processes_lock to ensure that
+    // only the desired child receives the handle.
+    if (new_options.stdout_handle) {
+      ::SetHandleInformation(new_options.stdout_handle, HANDLE_FLAG_INHERIT,
+                             HANDLE_FLAG_INHERIT);
+    }
+#endif
+
     process = LaunchProcess(command_line, new_options);
+
+#if defined(OS_WIN)
+    // Revoke inheritance so that the handle isn't leaked into other children.
+    // Note that this is done under g_live_processes_lock to ensure that only
+    // the desired child receives the handle.
+    if (new_options.stdout_handle)
+      ::SetHandleInformation(new_options.stdout_handle, HANDLE_FLAG_INHERIT, 0);
+#endif
+
     if (!process.IsValid())
       return -1;
 
     // TODO(rvargas) crbug.com/417532: Don't store process handles.
     g_live_processes.Get().insert(std::make_pair(process.Handle(),
                                                  command_line));
   }
 
   if (!launched_callback.is_null())
     launched_callback.Run(process.Handle(), process.Pid());
@@ skipping 52 matching lines @@
 
   // Redirect child process output to a file.
   FilePath output_file;
   CHECK(CreateTemporaryFile(&output_file));
 
   LaunchOptions options;
 #if defined(OS_WIN)
   win::ScopedHandle handle;
 
   if (redirect_stdio) {
-    // Make the file handle inheritable by the child.
-    SECURITY_ATTRIBUTES sa_attr;
-    sa_attr.nLength = sizeof(SECURITY_ATTRIBUTES);
-    sa_attr.lpSecurityDescriptor = NULL;
-    sa_attr.bInheritHandle = TRUE;
-
-    handle.Set(CreateFile(output_file.value().c_str(),
-                          GENERIC_WRITE,
-                          FILE_SHARE_READ | FILE_SHARE_DELETE,
-                          &sa_attr,
-                          OPEN_EXISTING,
-                          FILE_ATTRIBUTE_TEMPORARY,
-                          NULL));
+    handle.Set(CreateFile(output_file.value().c_str(), GENERIC_WRITE,
+                          FILE_SHARE_READ | FILE_SHARE_DELETE, nullptr,
+                          OPEN_EXISTING, FILE_ATTRIBUTE_TEMPORARY, NULL));
     CHECK(handle.IsValid());
     options.inherit_handles = true;
     options.stdin_handle = INVALID_HANDLE_VALUE;
     options.stdout_handle = handle.Get();
     options.stderr_handle = handle.Get();
   }
 
   if (test_launch_options.inherit_handles) {
     if (!options.inherit_handles) {
       options.inherit_handles = true;
@@ skipping 797 matching lines @@
   }
 
   std::string snippet(full_output.substr(run_pos));
   if (end_pos != std::string::npos)
     snippet = full_output.substr(run_pos, end_pos - run_pos);
 
   return snippet;
 }
 
 }  // namespace base