Various cleanups.

Various cleanups.

From comments in https://codereview.chromium.org/2663003003/.

BUG=none
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2670133002
Cr-Commit-Position: refs/heads/master@{#447964}
Committed: https://chromium.googlesource.com/chromium/src/+/396eeffed2b657b76749bcd9d9e207ce3a8619d1

[grt (UTC plus 2), 2017-02-02 08:16:38]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[grt (UTC plus 2), 2017-02-02 08:16:48]

PTAL

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/mini_installer.cc (right):

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/mini_installer.cc:98: for (bool binaries :
kValues) {
i get this compile error:

mini_installer.cc(122): error C3861: '<begin>': identifier not found
mini_installer.cc(122): error C3312: no callable 'begin' function found for type
'initializer list'
mini_installer.cc(122): error C3861: '<end>': identifier not found
mini_installer.cc(122): error C3312: no callable 'end' function found for type
'initializer list'
mini_installer.cc(124): error C2065: 'binaries': undeclared identifier

when i try:
  for (bool binaries : {false, true}) {

despite seeing that pattern elsewhere in the code. odd.

[commit-bot: I haz the power, 2017-02-02 08:18:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 08:49:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 08:49:29]

Dry run: This issue passed the CQ dry run.

[huangs, 2017-02-02 16:06:03]

LGTM, with comment re. {false, true}.

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/configuration_test.cc (right):

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/configuration_test.cc:73: #endif  //
!GOOGLE_CHROME_BUILD
I think the "!" is a bit confusing; should it be in #else?  NVM if that's the
convention.

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/mini_installer.cc (right):

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/mini_installer.cc:98: for (bool binaries :
kValues) {
Ah interesting. It seems this requires

#include <initializer_list>

which commonly gets transitively included (e.g., by <utility>), but happens to
be missing in this case.

[grt (UTC plus 2), 2017-02-03 07:45:47]

Thanks

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/configuration_test.cc (right):

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/configuration_test.cc:73: #endif  //
!GOOGLE_CHROME_BUILD
On 2017/02/02 16:06:03, huangs wrote:
> I think the "!" is a bit confusing; should it be in #else?  NVM if that's the
> convention.

I started doing this in a previous life so that the comment documents the logic
of the block that is being closed. Not knowing that, I can see how odd it looks.
Thanks for the perspective. I'll remove it.

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
File chrome/installer/mini_installer/mini_installer.cc (right):

https://codereview.chromium.org/2670133002/diff/1/chrome/installer/mini_insta...
chrome/installer/mini_installer/mini_installer.cc:98: for (bool binaries :
kValues) {
On 2017/02/02 16:06:03, huangs wrote:
> Ah interesting. It seems this requires
> 
> #include <initializer_list>
> 
> which commonly gets transitively included (e.g., by <utility>), but happens to
> be missing in this case.

Sweet! Thanks for the tip!

[grt (UTC plus 2), 2017-02-03 07:46:05]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-02-03 07:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from huangs@chromium.org
Link to the patchset: https://codereview.chromium.org/2670133002/#ps20001
(title: "huangs comments")

[commit-bot: I haz the power, 2017-02-03 07:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 08:36:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486107965826600,
"parent_rev": "30592452633a1619a73c95b8ed631a30b491dca0", "commit_rev":
"396eeffed2b657b76749bcd9d9e207ce3a8619d1"}

[commit-bot: I haz the power, 2017-02-03 08:36:37]

Description was changed from

==========
Various cleanups.

From comments in https://codereview.chromium.org/2663003003/.

BUG=none
R=huangs@chromium.org
==========

to

==========
Various cleanups.

From comments in https://codereview.chromium.org/2663003003/.

BUG=none
R=huangs@chromium.org

Review-Url: https://codereview.chromium.org/2670133002
Cr-Commit-Position: refs/heads/master@{#447964}
Committed:
https://chromium.googlesource.com/chromium/src/+/396eeffed2b657b76749bcd9d9e2...
==========

[commit-bot: I haz the power, 2017-02-03 08:36:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/396eeffed2b657b76749bcd9d9e2...