Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/installer/mini_installer/mini_installer.cc

Issue 2670133002: Various cleanups. (Closed)
Patch Set: huangs comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer/mini_installer.cc
diff --git a/chrome/installer/mini_installer/mini_installer.cc b/chrome/installer/mini_installer/mini_installer.cc
index 50b6252041a5926f9f29416ac949d3ea63026c11..871ab23db434879325dabc0a177843a4986dde1c 100644
--- a/chrome/installer/mini_installer/mini_installer.cc
+++ b/chrome/installer/mini_installer/mini_installer.cc
@@ -37,6 +37,8 @@
#include <stdlib.h>
#include <stddef.h>
+#include <initializer_list>
+
#include "chrome/installer/mini_installer/appid.h"
#include "chrome/installer/mini_installer/configuration.h"
#include "chrome/installer/mini_installer/decompress.h"
@@ -59,11 +61,14 @@ struct Context {
PathString* setup_resource_path;
};
+// TODO(grt): Frame this in terms of whether or not the brand supports
+// integation with Omaha, where Google Update is the Google-specific fork of
+// the open-source Omaha project.
#if defined(GOOGLE_CHROME_BUILD)
// Opens the Google Update ClientState key. If |binaries| is false, opens the
// key for Google Chrome or Chrome SxS (canary). If |binaries| is true and an
// existing multi-install Chrome is being updated, opens the key for the
-// binaries; otherwise, returns false.
+// multi-install binaries; otherwise, returns false.
bool OpenInstallStateKey(const Configuration& configuration,
bool binaries,
RegKey* key) {
@@ -91,10 +96,10 @@ void WriteInstallResults(const Configuration& configuration,
// Write the value in Chrome ClientState key and in the binaries' if an
// existing multi-install Chrome is being updated.
- for (int i = 0; i < 2; ++i) {
+ for (bool binaries : {false, true}) {
RegKey key;
DWORD value;
- if (OpenInstallStateKey(configuration, i != 0, &key)) {
+ if (OpenInstallStateKey(configuration, binaries, &key)) {
if (key.ReadDWValue(kInstallerResultRegistryValue, &value) !=
ERROR_SUCCESS ||
value == 0) {
@@ -115,9 +120,9 @@ void WriteInstallResults(const Configuration& configuration,
void SetInstallerFlags(const Configuration& configuration) {
StackString<128> value;
- for (int i = 0; i < 2; ++i) {
+ for (bool binaries : {false, true}) {
RegKey key;
- if (!OpenInstallStateKey(configuration, i != 0, &key))
+ if (!OpenInstallStateKey(configuration, binaries, &key))
continue;
LONG ret = key.ReadSZValue(kApRegistryValue, value.get(), value.capacity());
« no previous file with comments | « chrome/installer/mini_installer/configuration_test.cc ('k') | chrome/installer/mini_installer/mini_installer_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698