Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2670093002: [bootstrapper] clear extras utils object after usage. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[bootstrapper] clear extras utils object after usage. The extras utils object will no longer be needed after bootstrapping, and can be cleared. R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2670093002 Cr-Commit-Position: refs/heads/master@{#42908} Committed: https://chromium.googlesource.com/v8/v8/+/45721b712e7179918cd79a3c8d7a6c5d1bd9adc7

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Yang
3 years, 10 months ago (2017-02-02 06:49:31 UTC) #1
jochen (gone - plz use gerrit)
lgtm once it compiles :)
3 years, 10 months ago (2017-02-03 06:27:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670093002/20001
3 years, 10 months ago (2017-02-03 06:42:46 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 07:12:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/45721b712e7179918cd79a3c8d7a6c5d1bd...

Powered by Google App Engine
This is Rietveld 408576698