Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: src/bootstrapper.cc

Issue 2670093002: [bootstrapper] clear extras utils object after usage. (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/contexts.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3110 matching lines...) Expand 10 before | Expand all | Expand 10 after
3121 if (natives_key->AsArrayIndex(&dummy_index)) break; 3121 if (natives_key->AsArrayIndex(&dummy_index)) break;
3122 Handle<Object> utils = isolate()->natives_utils_object(); 3122 Handle<Object> utils = isolate()->natives_utils_object();
3123 Handle<JSObject> global = isolate()->global_object(); 3123 Handle<JSObject> global = isolate()->global_object();
3124 JSObject::AddProperty(global, natives_key, utils, DONT_ENUM); 3124 JSObject::AddProperty(global, natives_key, utils, DONT_ENUM);
3125 break; 3125 break;
3126 } 3126 }
3127 } 3127 }
3128 3128
3129 // The utils object can be removed for cases that reach this point. 3129 // The utils object can be removed for cases that reach this point.
3130 native_context()->set_natives_utils_object(heap()->undefined_value()); 3130 native_context()->set_natives_utils_object(heap()->undefined_value());
3131 native_context()->set_extras_utils_object(heap()->undefined_value());
3131 } 3132 }
3132 3133
3133 3134
3134 void Bootstrapper::ExportFromRuntime(Isolate* isolate, 3135 void Bootstrapper::ExportFromRuntime(Isolate* isolate,
3135 Handle<JSObject> container) { 3136 Handle<JSObject> container) {
3136 Factory* factory = isolate->factory(); 3137 Factory* factory = isolate->factory();
3137 HandleScope scope(isolate); 3138 HandleScope scope(isolate);
3138 Handle<Context> native_context = isolate->native_context(); 3139 Handle<Context> native_context = isolate->native_context();
3139 #define EXPORT_PRIVATE_SYMBOL(NAME) \ 3140 #define EXPORT_PRIVATE_SYMBOL(NAME) \
3140 Handle<String> NAME##_name = factory->NewStringFromAsciiChecked(#NAME); \ 3141 Handle<String> NAME##_name = factory->NewStringFromAsciiChecked(#NAME); \
(...skipping 1699 matching lines...) Expand 10 before | Expand all | Expand 10 after
4840 } 4841 }
4841 4842
4842 4843
4843 // Called when the top-level V8 mutex is destroyed. 4844 // Called when the top-level V8 mutex is destroyed.
4844 void Bootstrapper::FreeThreadResources() { 4845 void Bootstrapper::FreeThreadResources() {
4845 DCHECK(!IsActive()); 4846 DCHECK(!IsActive());
4846 } 4847 }
4847 4848
4848 } // namespace internal 4849 } // namespace internal
4849 } // namespace v8 4850 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/contexts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698