Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2670053003:
RTCPeerConnection.getStats whitelist updated. (Closed)
|
Created:
3 years, 10 months ago by hbos_chromium Modified:
3 years, 10 months ago Reviewers:
hta - Chromium CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRTCPeerConnection.getStats whitelist updated.
Add type 'any' to be used if a member is about to change type so that
both old and new type is valid.
Change ssrc to 'any' and add a TODO to change it to 'number'.
Remove old members from whitelist now that the changes have been made
and rolled in.
BUG=webrtc:7065, webrtc:7066, webrtc:7064, chromium:653873
Review-Url: https://codereview.chromium.org/2670053003
Cr-Commit-Position: refs/heads/master@{#447789}
Committed: https://chromium.googlesource.com/chromium/src/+/6398f107d8df0d71f9c989ea1b73630136b580f3
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by hbos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== RTCPeerConnection.getStats whitelist updated. Add type 'any' to be used if a member is about to change type so that both old and new type is valid. Change ssrc to 'any' and add a TODO to change it to 'number'. Remove old members from whitelist now that the changes have been made and rolled in. BUG=webrtc:7065, webrtc:7066 ========== to ========== RTCPeerConnection.getStats whitelist updated. Add type 'any' to be used if a member is about to change type so that both old and new type is valid. Change ssrc to 'any' and add a TODO to change it to 'number'. Remove old members from whitelist now that the changes have been made and rolled in. BUG=webrtc:7065, webrtc:7066, webrtc:7064 ==========
hbos@chromium.org changed reviewers: + hta@chromium.org
Please take a look hta. Note: Not referencing the same bugs as in the "TODO(hbos)" comments that I removed since these have been merged into other bugs.
Description was changed from ========== RTCPeerConnection.getStats whitelist updated. Add type 'any' to be used if a member is about to change type so that both old and new type is valid. Change ssrc to 'any' and add a TODO to change it to 'number'. Remove old members from whitelist now that the changes have been made and rolled in. BUG=webrtc:7065, webrtc:7066, webrtc:7064 ========== to ========== RTCPeerConnection.getStats whitelist updated. Add type 'any' to be used if a member is about to change type so that both old and new type is valid. Change ssrc to 'any' and add a TODO to change it to 'number'. Remove old members from whitelist now that the changes have been made and rolled in. BUG=webrtc:7065, webrtc:7066, webrtc:7064, chromium:653873 ==========
lgtm
The CQ bit was unchecked by hbos@chromium.org
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486054274284310, "parent_rev":
"c0fce12d818db7e176c4f028b57fcc9b72138b62", "commit_rev":
"6398f107d8df0d71f9c989ea1b73630136b580f3"}
Message was sent while issue was closed.
Description was changed from ========== RTCPeerConnection.getStats whitelist updated. Add type 'any' to be used if a member is about to change type so that both old and new type is valid. Change ssrc to 'any' and add a TODO to change it to 'number'. Remove old members from whitelist now that the changes have been made and rolled in. BUG=webrtc:7065, webrtc:7066, webrtc:7064, chromium:653873 ========== to ========== RTCPeerConnection.getStats whitelist updated. Add type 'any' to be used if a member is about to change type so that both old and new type is valid. Change ssrc to 'any' and add a TODO to change it to 'number'. Remove old members from whitelist now that the changes have been made and rolled in. BUG=webrtc:7065, webrtc:7066, webrtc:7064, chromium:653873 Review-Url: https://codereview.chromium.org/2670053003 Cr-Commit-Position: refs/heads/master@{#447789} Committed: https://chromium.googlesource.com/chromium/src/+/6398f107d8df0d71f9c989ea1b73... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6398f107d8df0d71f9c989ea1b73... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
