Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8596)

Unified Diff: chrome/test/data/webrtc/peerconnection_getstats.js

Issue 2670053003: RTCPeerConnection.getStats whitelist updated. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webrtc/peerconnection_getstats.js
diff --git a/chrome/test/data/webrtc/peerconnection_getstats.js b/chrome/test/data/webrtc/peerconnection_getstats.js
index 7fa3333757bdf5a20da61810cde625504bcead6d..b1cc9246ab48a602387e3afc42e8698569c3672e 100644
--- a/chrome/test/data/webrtc/peerconnection_getstats.js
+++ b/chrome/test/data/webrtc/peerconnection_getstats.js
@@ -17,14 +17,13 @@ var gStatsWhitelist = new Map();
* @private
*/
var kRTCRTPStreamStats = new RTCStats_(null, {
- ssrc: 'string',
+ // TODO(hbos): As soon as |ssrc| has changed into a number, change to
+ // 'number'. https://bugs.chromium.org/p/webrtc/issues/detail?id=7065, 7066
+ ssrc: 'any',
associateStatsId: 'string',
isRemote: 'boolean',
mediaType: 'string',
trackId: 'string',
- // TODO(hbos): As soon as |mediaTrackId| has been renamed to |trackId|, remove
- // this line. crbug.com/657854
- mediaTrackId: 'string',
transportId: 'string',
codecId: 'string',
firCount: 'number',
@@ -123,9 +122,6 @@ var kRTCMediaStreamTrackStats = new RTCStats_(null, {
ended: 'boolean',
detached: 'boolean',
kind: 'string',
- // TODO(hbos): As soon as |ssrcIds| has been removed, remove this line.
- // crbug.com/659137
- ssrcIds: 'sequence_string',
frameWidth: 'number',
frameHeight: 'number',
framesPerSecond: 'number',
@@ -169,9 +165,6 @@ var kRTCTransportStats = new RTCStats_(null, {
bytesReceived: 'number',
rtcpTransportStatsId: 'string',
dtlsState: 'string',
- // TODO(hbos): As soon as |activeConnection| has been replaced by |dtlsState|,
- // remove this line. crbug.com/653873
- activeConnection: 'boolean',
selectedCandidatePairId: 'string',
localCertificateId: 'string',
remoteCertificateId: 'string',
@@ -380,6 +373,8 @@ function verifyStatsIsWhitelisted_(stats) {
throw failTest('stats.' + propertyName + ' is not a whitelisted ' +
'member: ' + stats[propertyName]);
}
+ if (whitelistedStats[propertyName] === 'any')
+ continue;
if (!whitelistedStats[propertyName].startsWith('sequence_')) {
if (typeof(stats[propertyName]) !== whitelistedStats[propertyName]) {
throw failTest('stats.' + propertyName + ' should have a different ' +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698