Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2670013005: Avoid resetting the zoom on the sync confirmation and sign-in error dialogs. (Closed)

Created:
3 years, 10 months ago by msarda
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Avoid resetting the zoom on the sync confirmation and sign-in error dialogs. This CL adds a hack to avoid a zoom reset problem on Windows HDPI screens. The effects are the following: 1. When the page zoom is 100% (default value), then the dialogs are corrently displayed even on high definition screens (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbbkE5RDRVbHNrbkU ) 2. when the page zoom is different than 100%, then the dialogs will be zoomed accordingly and will display scrollbars (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbYVhiM1Rya3BhRlk ). BUG=687499 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2667113003 Cr-Commit-Position: refs/heads/master@{#447584} (cherry picked from commit d81408d286b29382d824d1949616051f14f78719) Review-Url: https://codereview.chromium.org/2670013005 . Cr-Commit-Position: refs/branch-heads/2987@{#287} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/6cf76eab2364310f3e79b6ed80074b8b25a3c1c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/signin/signin_shared_css.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
msarda
3 years, 10 months ago (2017-02-03 13:29:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cf76eab2364310f3e79b6ed80074b8b25a3c1c7.

Powered by Google App Engine
This is Rietveld 408576698