Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2667113003: Avoid resetting the zoom on the sync confirmation and sign-in error dialogs. (Closed)

Created:
3 years, 10 months ago by msarda
Modified:
3 years, 10 months ago
Reviewers:
anthonyvd, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid resetting the zoom on the sync confirmation and sign-in error dialogs. This CL adds a hack to avoid a zoom reset problem on Windows HDPI screens. The effects are the following: 1. When the page zoom is 100% (default value), then the dialogs are corrently displayed even on high definition screens (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbbkE5RDRVbHNrbkU ) 2. when the page zoom is different than 100%, then the dialogs will be zoomed accordingly and will display scrollbars (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbYVhiM1Rya3BhRlk ). BUG=687499 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2667113003 Cr-Commit-Position: refs/heads/master@{#447584} Committed: https://chromium.googlesource.com/chromium/src/+/d81408d286b29382d824d1949616051f14f78719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/signin/signin_shared_css.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
msarda
Dan, Anthony, May I ask you to take a look at this CL which is ...
3 years, 10 months ago (2017-02-01 16:29:25 UTC) #3
anthonyvd
lgtm
3 years, 10 months ago (2017-02-01 16:32:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667113003/1
3 years, 10 months ago (2017-02-01 18:13:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/354843)
3 years, 10 months ago (2017-02-01 18:22:11 UTC) #8
Dan Beam
lgtm
3 years, 10 months ago (2017-02-01 18:53:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667113003/1
3 years, 10 months ago (2017-02-01 18:54:29 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 19:57:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d81408d286b29382d824d1949616...

Powered by Google App Engine
This is Rietveld 408576698