Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2669923004: Use TaskScheduler instead of blocking pool in google_update_metrics_provider_win.cc. (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of blocking pool in google_update_metrics_provider_win.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rkaplow@chromium.org Review-Url: https://codereview.chromium.org/2669923004 Cr-Commit-Position: refs/heads/master@{#448072} Committed: https://chromium.googlesource.com/chromium/src/+/0d37fb09c9d1bf3657f67cd0c5ca916b8d122fe6

Patch Set 1 #

Patch Set 2 : upload #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M chrome/browser/metrics/google_update_metrics_provider_win.h View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/metrics/google_update_metrics_provider_win.cc View 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fdoray
Hi! I'm a Python script responsible for migrating tasks from the blocking pool to TaskScheduler. ...
3 years, 10 months ago (2017-02-03 17:32:15 UTC) #1
rkaplow
lgtm
3 years, 10 months ago (2017-02-03 20:59:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669923004/20001
3 years, 10 months ago (2017-02-03 21:03:09 UTC) #8
Alexei Svitkine (slow)
https://codereview.chromium.org/2669923004/diff/20001/chrome/browser/metrics/google_update_metrics_provider_win.h File chrome/browser/metrics/google_update_metrics_provider_win.h (right): https://codereview.chromium.org/2669923004/diff/20001/chrome/browser/metrics/google_update_metrics_provider_win.h#newcode53 chrome/browser/metrics/google_update_metrics_provider_win.h:53: static GoogleUpdateMetrics GetGoogleUpdateDataBlocking(); Nit: This function name doesn't make ...
3 years, 10 months ago (2017-02-03 21:05:16 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 21:35:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d37fb09c9d1bf3657f67cd0c5ca...

Powered by Google App Engine
This is Rietveld 408576698