Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: chrome/browser/metrics/google_update_metrics_provider_win.h

Issue 2669923004: Use TaskScheduler instead of blocking pool in google_update_metrics_provider_win.cc. (Closed)
Patch Set: upload Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/google_update_metrics_provider_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_GOOGLE_UPDATE_METRICS_PROVIDER_WIN_H_ 5 #ifndef CHROME_BROWSER_METRICS_GOOGLE_UPDATE_METRICS_PROVIDER_WIN_H_
6 #define CHROME_BROWSER_METRICS_GOOGLE_UPDATE_METRICS_PROVIDER_WIN_H_ 6 #define CHROME_BROWSER_METRICS_GOOGLE_UPDATE_METRICS_PROVIDER_WIN_H_
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 base::Time last_checked; 43 base::Time last_checked;
44 44
45 // Details about Google Update's attempts to update itself. 45 // Details about Google Update's attempts to update itself.
46 GoogleUpdateSettings::ProductData google_update_data; 46 GoogleUpdateSettings::ProductData google_update_data;
47 47
48 // Details about Google Update's attempts to update this product. 48 // Details about Google Update's attempts to update this product.
49 GoogleUpdateSettings::ProductData product_data; 49 GoogleUpdateSettings::ProductData product_data;
50 }; 50 };
51 51
52 // Retrieve the Google Update data on the blocking pool. 52 // Retrieve the Google Update data on the blocking pool.
53 static GoogleUpdateMetrics GetGoogleUpdateDataOnBlockingPool(); 53 static GoogleUpdateMetrics GetGoogleUpdateDataBlocking();
Alexei Svitkine (slow) 2017/02/03 21:05:16 Nit: This function name doesn't make sense to me a
54 54
55 // Receives |google_update_metrics| from a blocking pool thread and runs 55 // Receives |google_update_metrics| from a blocking pool thread and runs
56 // |done_callback|. 56 // |done_callback|.
57 void ReceiveGoogleUpdateData( 57 void ReceiveGoogleUpdateData(
58 const base::Closure& done_callback, 58 const base::Closure& done_callback,
59 const GoogleUpdateMetrics& google_update_metrics); 59 const GoogleUpdateMetrics& google_update_metrics);
60 60
61 // Google Update metrics that were fetched via GetGoogleUpdateData(). Will be 61 // Google Update metrics that were fetched via GetGoogleUpdateData(). Will be
62 // filled in only after the successful completion of GetGoogleUpdateData(). 62 // filled in only after the successful completion of GetGoogleUpdateData().
63 GoogleUpdateMetrics google_update_metrics_; 63 GoogleUpdateMetrics google_update_metrics_;
64 64
65 base::WeakPtrFactory<GoogleUpdateMetricsProviderWin> weak_ptr_factory_; 65 base::WeakPtrFactory<GoogleUpdateMetricsProviderWin> weak_ptr_factory_;
66 66
67 DISALLOW_COPY_AND_ASSIGN(GoogleUpdateMetricsProviderWin); 67 DISALLOW_COPY_AND_ASSIGN(GoogleUpdateMetricsProviderWin);
68 }; 68 };
69 69
70 #endif // CHROME_BROWSER_METRICS_GOOGLE_UPDATE_METRICS_PROVIDER_WIN_H_ 70 #endif // CHROME_BROWSER_METRICS_GOOGLE_UPDATE_METRICS_PROVIDER_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/google_update_metrics_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698