Issue 2669663004: Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime.

Issue 2669663004: Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime. (Closed)

Created:
3 years, 10 months ago by Raymond Toy

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime. The actual automation name is cancelAndHoldAtTime, not cancelValuesAndHoldAtTime: https://webaudio.github.io/web-audio-api/#widl-AudioParam-cancelAndHoldAtTime-AudioParam-double-cancelTime Make it so. BUG=686242 TEST=AudioParam/audioparam-cancel-and-hold.html Review-Url: https://codereview.chromium.org/2655073009 Cr-Commit-Position: refs/heads/master@{#447281} (cherry picked from commit f5e8986bdcd359c7ca82d83907c81642dd01f55e)

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -19 lines)			Patch
M	third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioParam.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioParam.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioParam.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Actually fixed in crrev.com/2655073009