Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2655073009: Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime. (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
tkent, hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime. The actual automation name is cancelAndHoldAtTime, not cancelValuesAndHoldAtTime: https://webaudio.github.io/web-audio-api/#widl-AudioParam-cancelAndHoldAtTime-AudioParam-double-cancelTime Make it so. BUG=686242 TEST=AudioParam/audioparam-cancel-and-hold.html Review-Url: https://codereview.chromium.org/2655073009 Cr-Commit-Position: refs/heads/master@{#447281} Committed: https://chromium.googlesource.com/chromium/src/+/f5e8986bdcd359c7ca82d83907c81642dd01f55e

Patch Set 1 #

Patch Set 2 : Update test result #

Patch Set 3 : Rebase expected results #

Messages

Total messages: 20 (11 generated)
Raymond Toy
PTAL. We mistakenly implemented the wrong name. I didn't write an intent for this. Do ...
3 years, 10 months ago (2017-01-27 22:09:09 UTC) #2
tkent
On 2017/01/27 at 22:09:09, rtoy wrote: > PTAL. > > We mistakenly implemented the wrong ...
3 years, 10 months ago (2017-01-30 00:08:29 UTC) #7
Raymond Toy
On 2017/01/30 00:08:29, tkent wrote: > On 2017/01/27 at 22:09:09, rtoy wrote: > > PTAL. ...
3 years, 10 months ago (2017-01-30 16:36:07 UTC) #8
hongchan
lgtm
3 years, 10 months ago (2017-01-30 18:02:37 UTC) #9
tkent
lgtm
3 years, 10 months ago (2017-01-30 23:00:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655073009/20001
3 years, 10 months ago (2017-01-30 23:04:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/373503)
3 years, 10 months ago (2017-01-31 00:53:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655073009/40001
3 years, 10 months ago (2017-01-31 16:38:32 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 18:48:07 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f5e8986bdcd359c7ca82d83907c8...

Powered by Google App Engine
This is Rietveld 408576698