DevTools: rebaseline debugger tests

DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html - old baseline
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html - test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol method didn't exist

BUG=682078
Review-Url: https://codereview.chromium.org/2669633002
Cr-Commit-Position: refs/heads/master@{#447371}
Committed: https://chromium.googlesource.com/chromium/src/+/0395da22a30f257cfc5a93783de7991fdb52e7b9

[chenwilliam, 2017-01-31 19:15:24]

Description was changed from

==========
inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html


inspector/sources/debugger/source-frame-breakpoint-decorations.html


inspector/sources/debugger/rethrow-error-from-bindings-crash.html


inspector/sources/debugger/properties-special.html


inspector/sources/debugger/debugger-scope-minified-variables.html


inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html


inspector/sources/debugger-ui/function-generator-details.html


inspector/sources/debugger-ui/debugger-save-to-temp-var.html


inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html


inspector/sources/debugger-frameworks/frameworks-steppings.html


inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline


inspector/sources/debugger-frameworks/frameworks-skip-step-in.html - seems like
current baseline is regression


inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
test didn't exist


inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist


inspector/sources/debugger-breakpoints/nodejs-set-breakpoint.html


inspector/sources/debugger-async/async-callstack-promises.html


inspector/sources/debugger-async/async-callstack-in-console.html

BUG=
==========

to

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html - seems like
current baseline is regression
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078
==========

[chenwilliam, 2017-01-31 19:15:25]

chenwilliam@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[chenwilliam, 2017-01-31 19:16:22]

Description was changed from

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html - seems like
current baseline is regression
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078
==========

to

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html - seems like
current baseline is regression
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
- test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078
==========

[chenwilliam, 2017-01-31 19:17:41]

ptal. I've rebaselined a good chunk of the debugger tests that were failing when
running against the old content shell (protocol 1.2).

https://codereview.chromium.org/2669633002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
(right):

https://codereview.chromium.org/2669633002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js:730: var
bookmark = bookmarks[index];
Added this because I was getting an error that the bookmark wasn't found for the
source-frame-inline-breakpoint-decorations.html test. @kozy, do you have a
better idea on handling this?

https://codereview.chromium.org/2669633002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt
(left):

https://codereview.chromium.org/2669633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt:5:
error: Request Debugger.getPossibleBreakpoints failed.
{"code":-32601,"message":"'Debugger.getPossibleBreakpoints' wasn't found"}
I had committed this earlier as an example protocol-1.2 baseline.

https://codereview.chromium.org/2669633002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt
(left):

https://codereview.chromium.org/2669633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt:22:
* 1) Framework.safeRun (framework.js:8)
Seems like the current baseline is a regression? Shouldn't these framework calls
not be shown in the call stack?

[kozy, 2017-01-31 20:12:02]

lgtm

[chenwilliam, 2017-01-31 21:08:12]

Description was changed from

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html - seems like
current baseline is regression
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
- test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078
==========

to

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
- test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078
==========

[chenwilliam, 2017-01-31 21:08:38]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-01-31 21:08:38]

dgozman@chromium.org: ptal

[dgozman, 2017-01-31 21:16:20]

lgtm

[chenwilliam, 2017-01-31 22:03:03]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-01-31 22:03:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2669633002/#ps20001
(title: "fix comment for frameworks-skip-step-in.html")

[commit-bot: I haz the power, 2017-01-31 22:03:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:58:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485900183677690,
"parent_rev": "8af85f21e7a0ff7be805f3ed4e56b96fe3b272d7", "commit_rev":
"0395da22a30f257cfc5a93783de7991fdb52e7b9"}

[commit-bot: I haz the power, 2017-01-31 23:58:51]

Description was changed from

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
- test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078
==========

to

==========
DevTools: rebaseline debugger tests

inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
- old baseline
inspector/sources/debugger-breakpoints/use-possible-breakpoints-to-resolve-breakpoint.html
- test didn't exist
inspector/sources/debugger-breakpoints/possible-breakpoints.html - protocol
method didn't exist

BUG=682078

Review-Url: https://codereview.chromium.org/2669633002
Cr-Commit-Position: refs/heads/master@{#447371}
Committed:
https://chromium.googlesource.com/chromium/src/+/0395da22a30f257cfc5a93783de7...
==========

[commit-bot: I haz the power, 2017-01-31 23:58:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0395da22a30f257cfc5a93783de7...