Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

Issue 2669633002: DevTools: rebaseline debugger tests (Closed)
Patch Set: fix comment for frameworks-skip-step-in.html Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
index 5765c5d525f7e7d9d239ec8f0c20db0955f52b91..3b20845fdfc605ac5ab712be6086a6856b1253c3 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
@@ -720,14 +720,20 @@ InspectorTest.dumpJavaScriptSourceFrameBreakpoints = function(sourceFrame)
}
}
-InspectorTest.clickJavaScriptSourceFrameBreakpoint = function(sourceFrame, lineNumber, index)
+InspectorTest.clickJavaScriptSourceFrameBreakpoint = function(sourceFrame, lineNumber, index, next)
{
var textEditor = sourceFrame._textEditor;
var lineLength = textEditor.line(lineNumber).length;
var lineRange = new Common.TextRange(lineNumber, 0, lineNumber, lineLength);
var bookmarks = textEditor.bookmarks(lineRange, Sources.JavaScriptSourceFrame.BreakpointDecoration._bookmarkSymbol);
bookmarks.sort((bookmark1, bookmark2) => bookmark1.position().startColumn - bookmark2.position().startColumn);
- bookmarks[index][Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest].click();
+ var bookmark = bookmarks[index];
+ if (bookmark) {
+ bookmark[Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest].click();
+ } else {
+ InspectorTest.addResult(`Could not click on Javascript breakpoint - lineNumber: ${lineNumber}, index: ${index}`);
+ next();
+ }
}
};
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698