Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2669283003: [Sync] Add ProfileSyncService::GetModelTypeStoreFactory. (Closed)

Created:
3 years, 10 months ago by pavely
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Sync] Add ProfileSyncService::GetModelTypeStoreFactory. This allows other model types besides DEVICE_INFO to create ModelTypeStores that share the same LevelDB backend. BUG=685451 Review-Url: https://codereview.chromium.org/2658743002 Cr-Commit-Position: refs/heads/master@{#446372} (cherry picked from commit 9f1ddc6deb94f709ca8a8635d270749560295a72) Review-Url: https://codereview.chromium.org/2669283003 . Cr-Commit-Position: refs/branch-heads/2987@{#283} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2ebeaa02e3d830ebd339be4134252682fe600330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.cc View 1 chunk +6 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.h View 4 chunks +9 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M components/browser_sync/profile_sync_test_util.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/sync/device_info/device_info_sync_bridge.h View 1 chunk +1 line, -4 lines 0 comments Download
M components/sync/device_info/device_info_sync_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/model/model_type_store.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
pavely
3 years, 10 months ago (2017-02-02 22:04:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ebeaa02e3d830ebd339be4134252682fe600330.

Powered by Google App Engine
This is Rietveld 408576698