Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2658743002: [Sync] Add ProfileSyncService::GetModelTypeStoreFactory. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add ProfileSyncService::GetModelTypeStoreFactory. This allows other model types besides DEVICE_INFO to create ModelTypeStores that share the same LevelDB backend. BUG=685451 Review-Url: https://codereview.chromium.org/2658743002 Cr-Commit-Position: refs/heads/master@{#446372} Committed: https://chromium.googlesource.com/chromium/src/+/9f1ddc6deb94f709ca8a8635d270749560295a72

Patch Set 1 #

Patch Set 2 : Fix iOS test util. #

Patch Set 3 : Fix iOS PSS factory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.cc View 1 chunk +6 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.h View 4 chunks +9 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M components/browser_sync/profile_sync_test_util.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/sync/device_info/device_info_sync_bridge.h View 1 chunk +1 line, -4 lines 0 comments Download
M components/sync/device_info/device_info_sync_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/model/model_type_store.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 22 (18 generated)
maxbogue
Sky, PTAL!
3 years, 11 months ago (2017-01-26 03:39:27 UTC) #12
skym
lgtm
3 years, 11 months ago (2017-01-26 16:03:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658743002/30001
3 years, 11 months ago (2017-01-26 17:41:28 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 17:49:51 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/9f1ddc6deb94f709ca8a8635d270...

Powered by Google App Engine
This is Rietveld 408576698