Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2669263005: [foozzie] Fix test cases (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Fix test cases BUG=chromium:673246 NOTRY=true TBR=mstarzinger,jarin Review-Url: https://codereview.chromium.org/2669263005 Cr-Commit-Position: refs/heads/master@{#42930} Committed: https://chromium.googlesource.com/v8/v8/+/52961c2f25d42fefd0a91a14015f343d9aa9d846

Patch Set 1 #

Patch Set 2 : [foozzie] Fix test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/foozzie/testdata/failure_output.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/foozzie/testdata/v8_build_config.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/foozzie/v8_foozzie_test.py View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael Achenbach
TBR - didn't run the tests for the last 3 CLs :/ This cuts the ...
3 years, 10 months ago (2017-02-03 13:12:33 UTC) #3
tandrii(chromium)
lgtm
3 years, 10 months ago (2017-02-03 13:26:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669263005/20001
3 years, 10 months ago (2017-02-03 14:33:21 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 14:35:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/52961c2f25d42fefd0a91a14015f343d9aa...

Powered by Google App Engine
This is Rietveld 408576698