Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/foozzie/v8_foozzie_test.py

Issue 2669263005: [foozzie] Fix test cases (Closed)
Patch Set: [foozzie] Fix test cases Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/foozzie/testdata/v8_build_config.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_foozzie_test.py
diff --git a/tools/foozzie/v8_foozzie_test.py b/tools/foozzie/v8_foozzie_test.py
index ba44828a37880b67e10df5cfc8e0d4f46a3401f0..4452fde0cb8617d5fcfeb8b73238e26bbc55b932 100644
--- a/tools/foozzie/v8_foozzie_test.py
+++ b/tools/foozzie/v8_foozzie_test.py
@@ -85,6 +85,10 @@ otherfile.js: TypeError: undefined is not a constructor
self.assertEquals(diff, suppress.diff(one, two))
+def cut_verbose_output(stdout):
+ return '\n'.join(stdout.split('\n')[2:])
+
+
def run_foozzie(first_d8, second_d8):
return subprocess.check_output([
sys.executable, FOOZZIE,
@@ -100,7 +104,7 @@ def run_foozzie(first_d8, second_d8):
class SystemTest(unittest.TestCase):
def testSyntaxErrorDiffPass(self):
stdout = run_foozzie('test_d8_1.py', 'test_d8_2.py')
- self.assertEquals('# V8 correctness - pass\n', stdout)
+ self.assertEquals('# V8 correctness - pass\n', cut_verbose_output(stdout))
def testDifferentOutputFail(self):
with open(os.path.join(TEST_DATA, 'failure_output.txt')) as f:
@@ -109,4 +113,4 @@ class SystemTest(unittest.TestCase):
run_foozzie('test_d8_1.py', 'test_d8_3.py')
e = ctx.exception
self.assertEquals(v8_foozzie.RETURN_FAIL, e.returncode)
- self.assertEquals(expected_output, e.output)
+ self.assertEquals(expected_output, cut_verbose_output(e.output))
« no previous file with comments | « tools/foozzie/testdata/v8_build_config.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698