third_party/WebKit/Source/core/dom/CharacterData.h - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CharacterData.h

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/CharacterData.h

diff --git a/third_party/WebKit/Source/core/dom/CharacterData.h b/third_party/WebKit/Source/core/dom/CharacterData.h

index 7f93e29b398778e36e22d491445223bd9e518a93..ff68ecac5312336191cd6f463ab2b069746dbefb 100644

--- a/third_party/WebKit/Source/core/dom/CharacterData.h

+++ b/third_party/WebKit/Source/core/dom/CharacterData.h

@@ -58,7 +58,7 @@ class CORE_EXPORT CharacterData : public Node {

protected:

CharacterData(TreeScope& treeScope, const String& text, ConstructionType type)

- : Node(&treeScope, type), m_data(!text.isNull() ? text : emptyString()) {

+ : Node(&treeScope, type), m_data(!text.isNull() ? text : emptyString) {

DCHECK(type == CreateOther || type == CreateText ||

type == CreateEditingText);

}