third_party/WebKit/Source/core/dom/AttrTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/AttrTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/AttrTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/AttrTest.cpp b/third_party/WebKit/Source/core/dom/AttrTest.cpp

index c86b5232e0b8ac96f391d8b4c2711f14bac1837b..03b115a6082a34ff59ef21b67446dab7ceb5c723 100644

--- a/third_party/WebKit/Source/core/dom/AttrTest.cpp

+++ b/third_party/WebKit/Source/core/dom/AttrTest.cpp

@@ -34,8 +34,8 @@ Attr* AttrTest::createAttribute() {

TEST_F(AttrTest, InitialValueState) {

Attr* attr = createAttribute();

EXPECT_EQ(emptyAtom, attr->value());

- EXPECT_EQ(emptyString(), attr->toNode()->nodeValue());

- EXPECT_EQ(emptyString(), attr->textContent());

+ EXPECT_EQ(emptyString, attr->toNode()->nodeValue());

+ EXPECT_EQ(emptyString, attr->textContent());

}

TEST_F(AttrTest, SetValue) {