third_party/WebKit/Source/core/dom/CharacterData.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CharacterData.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/CharacterData.cpp

diff --git a/third_party/WebKit/Source/core/dom/CharacterData.cpp b/third_party/WebKit/Source/core/dom/CharacterData.cpp

index 6605cf0cdcaffbe291a42eb3b2a1d79e8ff1868b..47bd7ca3f66fe169625864b769e1fe198805ce72 100644

--- a/third_party/WebKit/Source/core/dom/CharacterData.cpp

+++ b/third_party/WebKit/Source/core/dom/CharacterData.cpp

@@ -41,7 +41,7 @@ void CharacterData::atomize() {

}

void CharacterData::setData(const String& data) {

- const String& nonNullData = !data.isNull() ? data : emptyString();

+ const String& nonNullData = !data.isNull() ? data : emptyString;

if (m_data == nonNullData)

return;